Skip to content

Social SDK: Update UFL Guide with new helper functions #7689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025

Conversation

markmandel
Copy link
Contributor

@markmandel markmandel commented Jul 15, 2025

Update documentation to show how to use Client::GetRelationshipsByGroup and Client::SetRelationshipGroupsUpdatedCallback.

@markmandel markmandel requested a review from a team as a code owner July 15, 2025 00:38
@markmandel markmandel added the social-sdk Feedback and PRs on Social SDK label Jul 15, 2025
@markmandel markmandel requested review from colinloretz and anthonydiscord and removed request for a team July 15, 2025 00:38
@markmandel markmandel force-pushed the social/ufl-helper-methods branch from ddfcc6c to 474b9ad Compare July 17, 2025 22:17
@markmandel
Copy link
Contributor Author

markmandel commented Jul 17, 2025

Preview (click to de-squish):
screencapture-localhost-3336-developers-docs-discord-social-sdk-development-guides-creating-a-unified-friends-list-2025-07-17-15_17_24

Copy link
Contributor

@anthonydiscord anthonydiscord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one nit and one question!

Comment on lines +28 to +30
The Discord friend list is ultimately constructed from two entities: Relationships, and Users. You can query
Relationships API to find everyone a user is a friend with, and the Users API to find the necessary extra information
for rendering the list, such as whether they are online or not.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this doesn't produce a visible change. Do we want to newline like this in the .mdx file? If yes I'll update mine to do the same! Makes it easier to read in the file but maybe slightly more annoying to edit unless it knows how to format the code after editing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer it, since it's easier to read in an editor, and it's less likely to merge conflict if the edits are spread over multiple lines - it's also likely my IDE formatter changed it.

But I also am not enforcing it as something that everyone need do 😄

markmandel and others added 2 commits July 18, 2025 22:10
Update documentation to show how to use
`Client::GetRelationshipsByGroup` and
`Client::SetRelationshipGroupsUpdatedCallback`.
Review upadate

Co-authored-by: Anthony <anthony.tesija@discordapp.com>
@markmandel markmandel force-pushed the social/ufl-helper-methods branch from 31efcc6 to 9c3d3be Compare July 18, 2025 22:14
@markmandel markmandel merged commit 1f2f730 into discord:main Jul 18, 2025
4 checks passed
@markmandel markmandel deleted the social/ufl-helper-methods branch July 18, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
social-sdk Feedback and PRs on Social SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy