-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Social SDK: Update UFL Guide with new helper functions #7689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social SDK: Update UFL Guide with new helper functions #7689
Conversation
ddfcc6c
to
474b9ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with one nit and one question!
docs/discord-social-sdk/development-guides/creating-a-unified-friends-list.mdx
Outdated
Show resolved
Hide resolved
The Discord friend list is ultimately constructed from two entities: Relationships, and Users. You can query | ||
Relationships API to find everyone a user is a friend with, and the Users API to find the necessary extra information | ||
for rendering the list, such as whether they are online or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this doesn't produce a visible change. Do we want to newline like this in the .mdx file? If yes I'll update mine to do the same! Makes it easier to read in the file but maybe slightly more annoying to edit unless it knows how to format the code after editing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally prefer it, since it's easier to read in an editor, and it's less likely to merge conflict if the edits are spread over multiple lines - it's also likely my IDE formatter changed it.
But I also am not enforcing it as something that everyone need do 😄
Update documentation to show how to use `Client::GetRelationshipsByGroup` and `Client::SetRelationshipGroupsUpdatedCallback`.
Review upadate Co-authored-by: Anthony <anthony.tesija@discordapp.com>
31efcc6
to
9c3d3be
Compare
Update documentation to show how to use
Client::GetRelationshipsByGroup
andClient::SetRelationshipGroupsUpdatedCallback
.