fixes #1481 and #320 #1655
Open
fixes #1481 and #320 #1655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and django-haystack#320 Pagination passes start_offset and end_offset to simple backend, but these values where not used at all. ALso the entire queryset was evaluated by len(qs) which leads to much larger querysets than useful.
afe1160 to
a15c9a4
Compare
|
I don't think those test results make any sense, here is what happend on my machine, passes nicely. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1481 and #320
Pagination passes start_offset and end_offset to simple backend, but these
values where not used at all. ALso the entire queryset was evaluated by len(qs)
which leads to much larger querysets than useful.