Replace type:'string' with type'text' for elasticsearch 5 compaitbility. #1676
Conversation
|
There are a number of failed tests using elasticsearch 5. I suspect even without the changes in this PR, several elasticsearch 5 tests will fail although they may be different failures. Some of the failures may because things that used to return |
|
Are these changes still needed? If so, please rebase on the current |
They are still needed. I note this issue was fixed in django-haystack/haystack/backends/elasticsearch7_backend.py by redefining DEFAULT_FIELD_MAPPING and FIELD_MAPPINGS. I think this is a better approach so I have changed this PR to apply that fix to django-haystack/haystack/backends/elasticsearch5_backend.py as well. |
|
for consistency with the change #1965 for ES7 these c/should be class variables and used in build_schema with self. |
The
stringtype is removed in elasticsearch 5. There is an automatic conversion totextbut this doesn't support parameters likeboost.Attempts to PUT
_mapping/modelresultwith items like'subject': {'type': 'string', 'analyzer': 'snowball', 'boost': 1.25},result in a 400 error with the exception{'error': {'root_cause': [{'type': 'illegal_argument_exception', 'reason': 'The [string] type is removed in 5.0 and automatic upgrade failed because parameters [boost] are not supported for automatic upgrades. You should now use either a [text] or [keyword] field instead for field [subject]'}], 'type': 'illegal_argument_exception', 'reason': 'The [string] type is removed in 5.0 and automatic upgrade failed because parameters [boost] are not supported for automatic upgrades. You should now use either a [text] or [keyword] field instead for field [subject]'}, 'status': 400}This PR modifies
backends/elasticsearch5_backend.pyto changestringtotextin the importedbackends/elasticsearch_backend.pysettingsDEFAULT_FIELD_MAPPINGandFIELD_MAPPINGS