Skip to content

Update test matrix for django v5.0 #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 31, 2023

https://pypi.org/project/Django

https://www.djangoproject.com/weblog/2023/dec/04/django-50-released

Django 4.1 has reached the end of extended support. The final security release (4.1.13) was issued on November 1st. All Django 4.1 users are encouraged to upgrade to Django 4.2 or later.

https://docs.djangoproject.com/en/stable/releases/5.0

Django 5.0 supports Python 3.10, 3.11, and 3.12.

https://docs.djangoproject.com/en/stable/faq/install/#what-python-version-can-i-use-with-django

Whoosh issues with Python 3.10+ are fixed in #1928 or #1929

@claudep
Copy link
Contributor

claudep commented Jan 6, 2024

It's nice to have a reference PR where tests pass, even if I'm reluctant to push as is. I still hope that we can make the solr tests pass at some point. May I ask you to make a new PR with only the version changes, that is mostly the changes in test.yml, pyproject.toml and tox.ini? Even it the tests are not green, we know now they are OK because of this one.

@cclauss cclauss force-pushed the Update-test-matrix-for-Django-v5.0 branch from 76ca23e to 063832b Compare January 6, 2024 23:45
@cclauss cclauss requested a review from claudep January 7, 2024 13:16
Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's go with this version that hopefully is a good step towards fixing the test suite!

@claudep claudep merged commit 233f7c0 into master Jan 7, 2024
@claudep claudep deleted the Update-test-matrix-for-Django-v5.0 branch January 7, 2024 21:31
@cclauss
Copy link
Contributor Author

cclauss commented Jan 7, 2024

a good step towards fixing the test suite!

Fixing wait-for-solr and dropping whoosh should get us to ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy