Fix SOLR setup under Github Actions #1959
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
django-haystack/haystack/admin.py Line 18 in ae7bd39 Change to |
|
replaced by #1960 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1917
As #1921 seems a bit stuck, I decided to pursue the same issue, but with smaller PRs.
We don't really need container networking right now, because the tests run directly on the runner and not inside a container, and while it's nice to have, we can deal with that in a separate PR. Same goes for switching the SOLR port from the custom 9001 back to standard 8983.
This does just one thing - configures the SOLR properly under GH actions, so that the tests run. Also, unlike #1921, I did the configuration in a separate shell script, so that it can be also used for local testing with docker, for example with running solr with
docker run -it --rm -p 9001:8983 solr:6and then running the same script locally...