fix bug in zone class wrt SOA/RRSig #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a SOA with an RRSIG.
This was referenced Aug 20, 2024
|
Thanks a lot for noticing and coming up with a PR! Did you also test if replacing a signed SOA still works? I wonder if the remembering only the SOA record alone (instead of its rrset) is even working in that case. If the license allows it, we could maybe import the sample zone file. |
|
re: replacing signed SOAs: I created a second test case for that. It seemed to work, but you should look at it carefully. I'm not 100% sure it addresses your question. re: the sample zone file: it was just the one I was able to find browsing google. You'd have to ask them ("The DNS Institute") about licensing. The properly-signed examples I have access to are all reverse-related and anyway have our own contacts all over them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated issue: #334
Its a few lines of changes to "Zone.addRecord()" that allow for ingesting zones that have both a SOA and an associated RRSig/SOA.
Additionally, there's a test case that demonstrates the bug (fails on 3.6.1, works if the fix is applied).