Skip to content

fix: make DocList.to_json() return str instead of bytes #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 1, 2023
Merged

fix: make DocList.to_json() return str instead of bytes #1769

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
058a65c
fix: make doclist to_json return str instead of bytes
JohannesMessner Sep 1, 2023
95fc952
test: adapt tests
JohannesMessner Sep 1, 2023
6b1e82e
fix: convert json str to bytes where it is now necessary
JohannesMessner Sep 1, 2023
04a3797
docs: adapt documentation
JohannesMessner Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: adapt tests 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
  • Loading branch information
@JohannesMessner
JohannesMessner committed Sep 1, 2023
commit 95fc952e8f2df046991640686af227b2ef5683d4
8 changes: 4 additions & 4 deletions tests/units/array/test_array_from_to_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ def _rand_vec_gen(tensor_type):
return vec

v = generate_docs(tensor_type)
bytes_ = v.to_json()
json_str = v.to_json()

v_after = DocVec[v.doc_type].from_json(bytes_, tensor_type=tensor_type)
v_after = DocVec[v.doc_type].from_json(json_str, tensor_type=tensor_type)

assert v_after.tensor_type == v.tensor_type
assert set(v_after._storage.columns.keys()) == set(v._storage.columns.keys())
Expand Down Expand Up @@ -125,9 +125,9 @@ class MyDoc(BaseDoc):
return vec

v = generate_docs()
bytes_ = v.to_json()
json_str = v.to_json()

v_after = DocVec[v.doc_type].from_json(bytes_, tensor_type=TensorFlowTensor)
v_after = DocVec[v.doc_type].from_json(json_str, tensor_type=TensorFlowTensor)

assert v_after.tensor_type == v.tensor_type
assert set(v_after._storage.columns.keys()) == set(v._storage.columns.keys())
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy