fix: use HTTP 409 to check if db is already loaded

fix input validation logic Signed-off-by: Tony Yang <tonyyanga@gmail.com>
docarray · JoanFM · Dec 19, 2023 · Dec 4, 2023 · Dec 5, 2023 · Dec 5, 2023
commit c6deb79c5029475de2f567f49860989b0938ed27
diff --git a/docarray/index/backends/epsilla.py b/docarray/index/backends/epsilla.py
@@ -62,12 +62,7 @@ def __init__(self, db_config=None, **kwargs):
             )
 
             if status_code != HTTPStatus.OK:
-                # Epsilla returns HTTP 500 when multiple clients connect to the same db
-                # Bug filed at https://github.com/epsilla-cloud/vectordb/issues/93
-                if status_code == HTTPStatus.INTERNAL_SERVER_ERROR and (
-                    "Database catalog file is already loaded" in response["message"]
-                    or "DB already exists" in response["message"]
-                ):
+                if status_code == HTTPStatus.CONFLICT:
                     self._logger.info(f'{self._db_config.db_name} already loaded.')
                 else:
                     raise IOError(
@@ -278,7 +273,7 @@ def validate_self_hosted_config(self):
             missing_attributes = [
                 attr
                 for attr in ["protocol", "host", "port", "db_path", "db_name"]
-                if getattr(self, attr, None) is not None
+                if getattr(self, attr, None) is None
             ]
 
             if missing_attributes:
@@ -290,7 +285,7 @@ def validate_cloud_config(self):
             missing_attributes_cloud = [
                 attr
                 for attr in ["cloud_project_id", "cloud_db_id", "api_key"]
-                if getattr(self, attr, None) is not None
+                if getattr(self, attr, None) is None
             ]
 
             if missing_attributes_cloud: