Skip to content

fix: fix DocList schema when using Pydantic V2 #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Mar 21, 2025
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
a864589
fix: try to fix doclist schema
Mar 8, 2024
951679c
chore: push tmp changes
Mar 8, 2024
febea8d
fix: make DocList properly a Generic
Mar 11, 2024
11eeb6a
fix: make DocList properly a Generic
Mar 11, 2024
3f4707f
Merge branch 'try-fix-doclist-schema' of https://github.com/docarray/…
Mar 11, 2024
a07919d
fix: undo some changes
Mar 11, 2024
5ec78bd
test: test fixes
Mar 12, 2024
50e191a
test: set test
Mar 13, 2024
949f185
fix: full test for fastapi
Mar 14, 2024
d626453
fix: try to make generic
Mar 14, 2024
f33c55f
Merge branch 'main' into try-fix-doclist-schema
Feb 25, 2025
4180a4e
test: fix some tests
Feb 25, 2025
d9782a4
Merge branch 'try-fix-doclist-schema' of https://github.com/docarray/…
Feb 25, 2025
fb13c65
fix: small tests
Feb 25, 2025
bfee17a
test: fix test
Feb 25, 2025
2f80c56
fix: small test fix
Feb 25, 2025
5ff2f68
test: change tests
Mar 12, 2025
00245aa
fix: try to fix all pydantic-v1 tests
Mar 13, 2025
40f9420
fix: fix small dynamic creation
Mar 13, 2025
cb9cc94
test: further fix tests
Mar 13, 2025
4f42c0b
test: new iteration
Mar 13, 2025
cfa7ea5
test: more tests
Mar 14, 2025
659b992
fix: tests
Mar 14, 2025
9c94394
test: fix schemas from new model
Mar 17, 2025
f422e88
fix: improve cleaning refs
Mar 18, 2025
c7e9bf6
fix: get from definitions
Mar 18, 2025
5d3e73f
fix: remove unneeded argument
Mar 18, 2025
e12c03a
fix: fix update
Mar 18, 2025
a6fef44
fix: handle ID optional
Mar 18, 2025
559c0ee
fix: remove problematic action
Mar 18, 2025
8265d95
fix: fix resp as json
Mar 19, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: more tests
  • Loading branch information
Joan Martinez committed Mar 14, 2025
commit cfa7ea5d007f029c70463729c9b15b3ef786491d
2 changes: 1 addition & 1 deletion docarray/array/doc_vec/doc_vec.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def _check_doc_field_not_none(field_name, doc):
if safe_issubclass(tensor.__class__, tensor_type):
field_type = tensor_type

if isinstance(field_type, type):
if isinstance(field_type, type) or safe_issubclass(field_type, AnyDocArray):
if tf_available and safe_issubclass(field_type, TensorFlowTensor):
# tf.Tensor does not allow item assignment, therefore the
# optimized way
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy