Skip to content

Silly fixes #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Mar 19, 2023
Merged

Silly fixes #1251

merged 29 commits into from
Mar 19, 2023

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Jan 22, 2023 •
edited
Loading

@Perksey
Copy link
Member Author

Perksey commented Feb 12, 2023

Clarification to the title of this PR: I'm not calling the issues themselves silly, I'm just calling the fix silly because it (should be) simple/not too much hardship.

Khitiara
Khitiara reviewed Feb 20, 2023
View reviewed changes
Khitiara
Khitiara reviewed Feb 21, 2023
View reviewed changes
@Perksey
Copy link
Member Author

Perksey commented Feb 26, 2023

Self review pending, will do tomorrow

@Perksey Perksey mentioned this pull request Mar 10, 2023
Merged
@Perksey
Copy link
Member Author

Perksey commented Mar 10, 2023

Ready for review.

This must not be merged until #1324 is merged.

Note that automation of submodule updating is not done yet, I'll do this in a separate PR as it'll be good to just get this one in now.

@Perksey Perksey marked this pull request as ready for review March 10, 2023 17:54
@Perksey Perksey requested review from ThomasMiz, HurricanKai and a team as code owners March 10, 2023 17:54
silkdotnet and others added 4 commits March 10, 2023 20:00
@silkdotnet @dotnet-bot @Perksey
New binaries for Assimp on Darwin 21.6.0 Darwin Kernel Version 21.6.0…
bf96747 
…: Mon Dec 19 20:44:01 PST 2022; root:xnu-8020.240.18~2/RELEASE_X86_64 (#1310)

Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
Co-authored-by: Dylan Perks <11160611+Perksey@users.noreply.github.com>
@silkdotnet @dotnet-bot
Regenerate bindings as of 10/03/2023 (#1324)
32ff294 
* Regenerated bindings as of 10/03/2023 (16:54:01)

* Regenerated bindings as of 10/03/2023 (17:35:57)

* Regenerated bindings as of 10/03/2023 (18:27:27)

---------

Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
@Perksey
Merge branch 'hotfix/silly_fixes' of https://github.com/dotnet/Silk.NET…
cd975a0 
… into hotfix/silly_fixes
@Perksey
Build fixes
ad4d41e
Beyley
Beyley reviewed Mar 12, 2023
View reviewed changes
@Beyley
Copy link
Contributor

Beyley commented Mar 13, 2023

CI seems to be failing, caused by there being no 0 element in the enum, but there being a None enum member already, with a non-0 value
https://github.com/dotnet/Silk.NET/blob/hotfix/silly_fixes/src/Microsoft/Silk.NET.Direct3D9/Enums/Cull.gen.cs
image

@Perksey
Copy link
Member Author

Perksey commented Mar 19, 2023

Fixed the erroneous None member thing, and I've also (as discussed in Discord) made it so we don't add [Flags] for sequential enums, and it's super effective!

@Perksey
Copy link
Member Author

Perksey commented Mar 19, 2023

Ready for rereview

@Perksey Perksey merged commit 4b7976b into main Mar 19, 2023
@Perksey Perksey deleted the hotfix/silly_fixes branch March 19, 2023 19:45
This was referenced Mar 26, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Khitiara Khitiara Khitiara left review comments

@Beyley Beyley Beyley approved these changes

@ThomasMiz ThomasMiz Awaiting requested review from ThomasMiz ThomasMiz is a code owner

@HurricanKai HurricanKai Awaiting requested review from HurricanKai HurricanKai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Perksey @Beyley @Khitiara @silkdotnet
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy