Skip to content

Regenerate bindings as of 10/03/2023 #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

silkdotnet
Copy link
Contributor

No description provided.

@silkdotnet silkdotnet requested review from Beyley, ThomasMiz, HurricanKai and a team as code owners March 10, 2023 16:54
Copy link
Member

@HurricanKai HurricanKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we dropped a lot of [Flags] is that intended?

@Perksey
Copy link
Member

Perksey commented Mar 10, 2023

Not intended, I'd expect a few Nones to be dropped but not [Flags]. Already have a fix on #1251, will rerun.

Comment on lines +16 to +17
[NativeName("Name", "")]
None = 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This oddity needs to be fixed - there's two Nones - one with 1 and one with 0.

@Perksey Perksey mentioned this pull request Mar 10, 2023
14 tasks
@Perksey Perksey merged commit 32ff294 into hotfix/silly_fixes Mar 10, 2023
@Perksey Perksey deleted the ci/hotfix/silly_fixes/bindings_regen branch March 10, 2023 20:02
Perksey added a commit that referenced this pull request Mar 19, 2023
* Start of silly fixes

* Fixes #1249

* Fixes #1155

* Add a comments section to the website

* Fix #821, fix #1094

* Fix #1093, fix #960

* Fix #1070

* Fix #1091

* Review comment, apply NativeAOT fix only on NS21+

* Add support for Vulkan specification specialization (SC), full regen

* Fix build

* Last silly fix

* Calm down

* Address review comments

* Build fixes

* How did that not work...

* Fix regen CI, only add None enum if there isn't a 0, update patch notes

* Include the pushable token for CI

* Don't remove the Flags attribute where unnecessary

* Remove problematic type, remove erroneous additions of None in enums

* New binaries for Assimp on Darwin 21.6.0 Darwin Kernel Version 21.6.0: Mon Dec 19 20:44:01 PST 2022; root:xnu-8020.240.18~2/RELEASE_X86_64 (#1310)

Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
Co-authored-by: Dylan Perks <11160611+Perksey@users.noreply.github.com>

* Regenerate bindings as of 10/03/2023 (#1324)

* Regenerated bindings as of 10/03/2023 (16:54:01)

* Regenerated bindings as of 10/03/2023 (17:35:57)

* Regenerated bindings as of 10/03/2023 (18:27:27)

---------

Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>

* Build fixes

* Review comments, update WebGPU?

* Fix Vulkan build errors

---------

Co-authored-by: silkdotnet <85832961+silkdotnet@users.noreply.github.com>
Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy