Skip to content

Minor proposal changes #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2021
Merged

Minor proposal changes #668

merged 3 commits into from
Nov 4, 2021

Conversation

WhiteBlackGoose
Copy link
Contributor

Summary of the PR

Updates to proposals

@WhiteBlackGoose WhiteBlackGoose marked this pull request as ready for review November 3, 2021 19:25
@Perksey
Copy link
Member

Perksey commented Nov 4, 2021

Needs working group sign-off, added to list for next meeting.

@Perksey Perksey added this to the Next Working Group Meeting milestone Nov 4, 2021
@WhiteBlackGoose
Copy link
Contributor Author

🙄 when is it going to be? Not is not going to work without AllBitsSet property

@Perksey
Copy link
Member

Perksey commented Nov 4, 2021

There's no date at the moment, and there's still feedback from the last working group meeting we need to address. Will try to work on that this evening/this weekend to further it along.

@WhiteBlackGoose
Copy link
Contributor Author

._. sounds beurocratic to me.

Now that means that my whole PR which implements AllBitsSets will be frozen for a while. Maybe I can remove Not and AllBitsSet from it though...

@Perksey Perksey removed this from the Next Working Group Meeting milestone Nov 4, 2021
Perksey
Perksey approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually on second glance this seems fine and is a continuation of the already-approved message of "like Scalar but with Vectors". The main thing I was concerned about in the details of the bitshifts, but it looks like there were addressed in the last meeting. Approving

@Perksey Perksey merged commit c21404c into dotnet:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perksey Perksey Perksey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WhiteBlackGoose @Perksey
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy