Skip to content

[5.1] Cherry-pick of #3270 - Handle null socket #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2025
Merged

[5.1] Cherry-pick of #3270 - Handle null socket #3285

merged 1 commit into from
Apr 19, 2025

Conversation

paulmedynski
Copy link
Contributor

@paulmedynski paulmedynski added this to the 5.1.7 milestone Apr 18, 2025
@paulmedynski paulmedynski requested a review from a team April 18, 2025 11:08
@codecov Codecov
Copy link

codecov bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.77%. Comparing base (60fc661) to head (9bf1576).
Report is 2 commits behind head on release/5.1.

Files with missing lines Patch % Lines
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release/5.1    #3285      +/-   ##
===============================================
- Coverage        71.89%   71.77%   -0.13%     
===============================================
  Files              293      293              
  Lines            61647    61650       +3     
===============================================
- Hits             44323    44247      -76     
- Misses           17324    17403      +79
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 75.88% <60.00%> (-0.23%) ⬇️
netfx 69.46% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski merged commit bd44051 into release/5.1 Apr 19, 2025
82 checks passed
@paulmedynski paulmedynski deleted the dev/paul/release/5.1-null-socket branch April 19, 2025 00:12
paulmedynski added a commit that referenced this pull request Apr 24, 2025
@paulmedynski
Added localizations for the new SNI_ERROR_10 code from PR #3285.
995c93d
paulmedynski added a commit that referenced this pull request Apr 25, 2025
@paulmedynski
Added localizations for the new SNI_ERROR_10 code from PR #3285. (#3300)
0697f41
apoorvdeshmukh added a commit that referenced this pull request Apr 28, 2025
@apoorvdeshmukh
Port localizations for the new SNI_ERROR_10 code from PR #3285
3056b31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdaigle mdaigle mdaigle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@paulmedynski @mdaigle @cheenamalhotra
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy