Skip to content

Modernize MSBuild Task Properties with Nullable Reference Types #10283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 14, 2025
Merged

Modernize MSBuild Task Properties with Nullable Reference Types #10283

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f5153f6
Initial plan
Copilot Jul 11, 2025
459011b
Modernize AndroidApkSigner.cs with nullable reference types
Copilot Jul 11, 2025
6878ee7
Modernize CalculateProjectDependencies and JavaToolTask with nullable…
Copilot Jul 11, 2025
e5ea654
Modernize ConvertCustomView, MergeRemapXml, and ImportJavaDoc with nu…
Copilot Jul 11, 2025
e6c3115
Modernize JavaDoc and JavaSourceUtils with nullable reference types
Copilot Jul 11, 2025
9016f5c
Modernize StripNativeLibraries and LinkApplicationSharedLibraries wit…
Copilot Jul 11, 2025
b373e4d
Phase 2: Add #nullable enable to first batch of files without nullabl…
Copilot Jul 11, 2025
0a4b6a8
Phase 2: Add #nullable enable to more files without nullable directives
Copilot Jul 11, 2025
ea6f239
Phase 2: Add #nullable enable to batch of simple files without string…
Copilot Jul 11, 2025
7e5255c
Phase 2: Continue adding #nullable enable to more simple files
Copilot Jul 11, 2025
7ad34ad
Fix nullable reference type compilation errors in modernized MSBuild …
Copilot Jul 11, 2025
8d968f4
Merge branch 'main' into copilot/fix-10277
jonathanpeppers Jul 11, 2025
69c5442
Fix remaining 5 nullable reference type compilation errors
Copilot Jul 11, 2025
e365427
Merge branch 'main' into copilot/fix-10277
jonathanpeppers Jul 14, 2025
baf6a13
Fix AndroidApkSigner nullable SDK version handling
Copilot Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Phase 2: Add #nullable enable to batch of simple files without string… 
….IsNullOrEmpty patterns

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
  • Loading branch information
@Copilot @jonathanpeppers
Copilot and jonathanpeppers committed Jul 11, 2025
commit ea6f239f845cef5f881a638c00eb45c6ef679cf9
2 changes: 2 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tasks/AssemblyModifierPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#nullable enable

using System;
using System.Collections.Generic;
using System.IO;
Expand Down
2 changes: 2 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tasks/CheckClientHandlerType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#nullable enable

using System;
using System.Collections.Generic;
using System.Linq;
Expand Down
2 changes: 2 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tasks/CheckDuplicateJavaLibraries.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#nullable enable

using System;
using System.IO;
using System.Linq;
Expand Down
2 changes: 2 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tasks/CheckForInvalidDesignerConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#nullable enable

using Microsoft.Android.Build.Tasks;
using Microsoft.Build.Framework;
using Microsoft.Build.Utilities;
Expand Down
2 changes: 2 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tasks/CheckProjectItems.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#nullable enable

using System;
using System.Collections.Generic;
using System.Linq;
Expand Down
2 changes: 2 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tasks/ClassParse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// Copyright (C) 2012 Xamarin, Inc. All rights reserved.

#nullable enable

using System.IO;
using Microsoft.Android.Build.Tasks;
using Microsoft.Build.Framework;
Expand Down
2 changes: 2 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tasks/CollectAssemblyFilesForArchive.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#nullable enable

using System;
using System.Collections.Generic;
using System.Linq;
Expand Down
2 changes: 2 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tasks/ComputeHash.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#nullable enable

using System.Collections.Generic;
using Microsoft.Build.Utilities;
using Microsoft.Build.Framework;
Expand Down
2 changes: 2 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tasks/CopyIfChanged.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// Copyright (C) 2011 Xamarin, Inc. All rights reserved.

#nullable enable

using System;
using System.Collections.Generic;
using System.IO;
Expand Down
2 changes: 2 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tasks/CopyResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// Author: Jonathan Pobst <jpobst@xamarin.com>
// Copyright (C) 2011 Xamarin, Inc. All rights reserved.

#nullable enable

using System.IO;
using Microsoft.Build.Framework;
using Microsoft.Build.Utilities;
Expand Down
2 changes: 2 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tasks/CreateAssemblyStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#nullable enable

using System;
using System.Collections.Generic;
using System.Linq;
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy