Skip to content

Always use assembly stores when assemblies are to be embedded #9410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Always use assembly stores when assemblies are to be embedded #9410

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d2b1f08
Always use assembly stores when assemblies are to be embedded
grendello Oct 16, 2024
6f7419f
Remove a lot of code to handle packaging of individual assemblies
grendello Oct 24, 2024
912b44c
Assembly stores are the only way to embed assemblies in the apk now
grendello Oct 28, 2024
5d031ee
Don't segfault when fastdev is used
grendello Oct 29, 2024
4c52fb3
Update apkdesc files
grendello Oct 30, 2024
0fd503c
Better `abort_unless` location reporting
grendello Oct 30, 2024
cf19401
Better FastDev handling
grendello Oct 30, 2024
1cf674a
Post rebase fixups
grendello Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Post rebase fixups
  • Loading branch information
@grendello
grendello committed Nov 25, 2024
commit 1cf674aa426990167d52a470da9bb63b179bcbdc
3 changes: 1 addition & 2 deletions src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/PackagingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,13 @@ public void CheckDebugModeWithTrimming ()
EmbedAssembliesIntoApk = true,
};
proj.SetProperty ("PublishTrimmed", "true");
proj.SetProperty ("AndroidUseAssemblyStore", usesAssemblyStores.ToString ());

using var b = CreateApkBuilder ();
Assert.IsTrue (b.Build (proj), "build should have succeeded.");

var apk = Path.Combine (Root, b.ProjectDirectory,
proj.OutputPath, $"{proj.PackageName}-Signed.apk");
var helper = new ArchiveAssemblyHelper (apk, usesAssemblyStores);
var helper = new ArchiveAssemblyHelper (apk);
helper.Contains (["Mono.Android.dll", $"{proj.ProjectName}.dll"], out _, out var missingFiles, out _, [AndroidTargetArch.Arm64, AndroidTargetArch.X86_64]);

Assert.IsTrue (missingFiles == null || missingFiles.Count == 0,
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy