Skip to content

Changes in embedded dirs should also trigger templates testing #62806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Changes in embedded dirs should also trigger templates testing #62806

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d56af9
Changes in embedded dirs should also trigger the job.
ilonatommy Jul 18, 2025
4a56f6a
Tmp change, to test if double wildcard is working.
ilonatommy Jul 18, 2025
069d8cb
Remove the tmp change.
ilonatommy Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tmp change, to test if double wildcard is working.
  • Loading branch information
@ilonatommy
ilonatommy committed Jul 18, 2025
commit 4a56f6aa6d1060fc11ba9ef24fec6e7336bb7d6e
16 changes: 9 additions & 7 deletions src/ProjectTemplates/test/Templates.Tests/BaselineTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,15 @@ public async Task Template_Produces_The_Right_Set_Of_FilesAsync(string arguments
foreach (var file in filesInFolder)
{
var relativePath = file.Replace(Project.TemplateOutputDir, "").Replace("\\", "/").Trim('/');
if (IsIgnoredPath(relativePath))
if (relativePath.EndsWith(".csproj", StringComparison.Ordinal) ||
relativePath.EndsWith(".fsproj", StringComparison.Ordinal) ||
relativePath.EndsWith(".props", StringComparison.Ordinal) ||
relativePath.EndsWith(".sln", StringComparison.Ordinal) ||
relativePath.EndsWith(".targets", StringComparison.Ordinal) ||
relativePath.StartsWith("bin/", StringComparison.Ordinal) ||
relativePath.StartsWith("obj/", StringComparison.Ordinal) ||
relativePath.Contains("/bin/", StringComparison.Ordinal) ||
relativePath.Contains("/obj/", StringComparison.Ordinal))
{
continue;
}
Expand All @@ -110,12 +118,6 @@ public async Task Template_Produces_The_Right_Set_Of_FilesAsync(string arguments
}
}

private static bool IsIgnoredPath(string relativePath) =>
relativePath.StartsWith("bin/", StringComparison.Ordinal) ||
relativePath.StartsWith("obj/", StringComparison.Ordinal) ||
relativePath.Contains("/bin/", StringComparison.Ordinal) ||
relativePath.Contains("/obj/", StringComparison.Ordinal);

private void AssertFileExists(string basePath, string path, bool shouldExist)
{
var fullPath = Path.Combine(basePath, path);
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy