Skip to content

[Java.Interop] ignore remaining trimming warnings #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 14, 2024
Merged

[Java.Interop] ignore remaining trimming warnings #1190

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7482f46
[Java.Interop] ignore remaining trimming warnings
jonathanpeppers Feb 13, 2024
33bd501
Cleaner suppressions around `Invoker` types
jonathanpeppers Feb 13, 2024
4522d35
Cleaner suppressions for `GetObjectArrayMarshaler`
jonathanpeppers Feb 13, 2024
9c7a05a
Cleaner suppressions for GetParameterMarshaler
jonathanpeppers Feb 13, 2024
5300682
Cleaner suppression for ManagedPeer
jonathanpeppers Feb 13, 2024
502e852
Cleaner suppression for JniRuntime.JniTypeManager.cs
jonathanpeppers Feb 13, 2024
a493d15
Formatting
jonathanpeppers Feb 13, 2024
ea2ff53
Update JniRuntime.JniTypeManager.cs
jonathanpeppers Feb 13, 2024
ad5019d
Update JniRuntime.JniTypeManager.cs
jonathanpeppers Feb 13, 2024
f6bb010
Formatting
jonathanpeppers Feb 14, 2024
aea690e
Extra newline
jonathanpeppers Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Formatting
  • Loading branch information
@jonathanpeppers
jonathanpeppers committed Feb 14, 2024
commit f6bb01051baa7d3971dc474eb36d57449143c384
2 changes: 1 addition & 1 deletion src/Java.Interop/Java.Interop/JniRuntime.JniValueManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ static Type GetPeerType ([DynamicallyAccessedMembers (Constructors)] Type type)
[UnconditionalSuppressMessage ("Trimming", "IL2026", Justification = assemblyGetTypeMessage)]
[UnconditionalSuppressMessage ("Trimming", "IL2073", Justification = assemblyGetTypeMessage)]
[return: DynamicallyAccessedMembers (Constructors)]
static Type? AssemblyGetType(Assembly assembly, string typeName) =>
static Type? AssemblyGetType (Assembly assembly, string typeName) =>
assembly.GetType (typeName);

// FIXME: https://github.com/xamarin/java.interop/issues/1192
Expand Down
2 changes: 1 addition & 1 deletion src/Java.Interop/Java.Interop/ManagedPeer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ static List<Type>[] GetConstructorCandidateParameterTypes (string signature)
{
// https://github.com/xamarin/xamarin-android/blob/5472eec991cc075e4b0c09cd98a2331fb93aa0f3/src/Microsoft.Android.Sdk.ILLink/MarkJavaObjects.cs#L51-L132
[UnconditionalSuppressMessage ("Trimming", "IL2072", Justification = "Constructors are preserved by the MarkJavaObjects trimmer step.")]
static object? ValueManagerGetValue(JniRuntime runtime, ref JniObjectReference value, ParameterInfo parameter) =>
static object? ValueManagerGetValue (JniRuntime runtime, ref JniObjectReference value, ParameterInfo parameter) =>
runtime.ValueManager.GetValue (ref value, JniObjectReferenceOptions.CopyAndDispose, parameter.ParameterType);

if (!values.IsValid)
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy