Seems like those WasmBuild failures might be related. Need to see what they look like.

@ilonatommy @lewing could you have a look at the wasm failures to tell me if they look like they are caused by this? I did modify some build tasks. Those test are doing builds, but I looked at logs and don't see any obvious assembly load failures which is what my change might cause.

these pinvoke failures with /p:EmccLinkOptimizationFlag=-O0 with AOT happen on net8 out of this PR, should be marked as known issue
(edit: the are caught by #104827, no new issue needed.)

SatelliteAssembliesTests are marked as known issue.

but these happen only on this PR.

Parameter types of pinvoke callback method 'System.Void SomeFunction1(System.Int32())' needs to be blittable

like in #92380.

I don't see a direct connection.

These tests are still failing on rerun so it does look like this change somehow caused it. I'm pulling down the tests locally to try a repro and see what's happening. It looks almost like it's not resolving the types correctly so it keeps them in System.Int32 form without recognizing they are value types that are blittable.

So it seems to be caused by removing System.Reflection.MetadataLoadContext.dll from Microsoft.NET.Runtime.WebAssembly.Sdk\8.0.15\tasks\net8.0. This is odd because the version that was shipping there before was the 7.0.0 version. I would have expected the task to be fine to load the version that ships with the SDK under dotnet\sdk\<version>\System.Reflection.MetadataLoadContext.dll.

To further test this, once adding back the local copy of Microsoft.NET.Runtime.WebAssembly.Sdk\8.0.15\tasks\net8.0\System.Reflection.MetadataLoadContext.dll and seeing the tests pass, I replaced that copy with the 8.0 copy from the SDK and they failed again. So this tells me that these tests will break when run with the latest S.R.MLC.

This is bad because the 7.0.0 version is no longer built nor supported.

@maraf @akoeplinger @lewing -- seems that you might have helped fix this previously in #97640 -- it may be related to S.R.MLC 8.0 supporting function pointers.

What should we backport to make these tests work correctly on the 8.0 S.R.MLC that's in the product (and allow us to remove the 7.0 version which is out of support).

The problem is that the code expects that path to throw and so it sees unexpected things when it doesn't. The code in 8 would take more extensive fixes to work properly in all the cases it will see now. I need to think about the best way to fix this.

It looks like Build Analysis is green now, do we take it? With the current content does it constitute a product change we need to take to tactics, or still infrastructure tell mode? @lewing

With the current content does it constitute a product change we need to take to tactics, or still infrastructure tell mode?

In theory the WasmAppBuilder changes should behave the same as before but it feels no longer like an infra change to me.

@akoeplinger / @lewing - can you please have a look at the servicing template added and make it correctly represent the changes / risk / testing to WasmAppBuilder? After that we can take it to tactics.

Ping @akoeplinger @lewing. The servicing branches are about to open.

Friendly reminder that code complete is on April 14th for the May Release. If you'd like to get this change included in that release, please get a Tactics approval and merge this PR before that date.

ah sorry, I replied to Eric on Teams. It looks good to me.