Fix some static analysis errors #114997
Merged
Fix some static analysis errors #114997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up static analysis issues flagged by internal compliance tools by ensuring proper operator usage and correcting parameter usage in string formatting.
- Replaced bitwise OR operators with logical OR in conditional expressions.
- Removed an extraneous parameter in a string formatting call.
- Adjusted conditional checks for method attributes.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/libraries/System.Threading.Channels/src/System/Threading/Channels/BoundedChannel.cs | Fixed a logical operation to use OR ( |
| src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/DirectoryServer.cs | Corrected operator usage in error code comparisons by replacing bitwise OR ( |
| src/libraries/System.Composition.TypedParts/src/System/Composition/TypedParts/ActivationFeatures/OnImportsSatisfiedFeature.cs | Updated the conditional check to use logical OR ( |
| src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/CompositionException.cs | Removed an unnecessary parameter from the string formatting call to match the expected format. |
src/libraries/System.Threading.Channels/src/System/Threading/Channels/BoundedChannel.cs
Show resolved
Hide resolved
...ies/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/DirectoryServer.cs
Show resolved
Hide resolved
...ies/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/DirectoryServer.cs
Show resolved
Hide resolved
...TypedParts/src/System/Composition/TypedParts/ActivationFeatures/OnImportsSatisfiedFeature.cs
Show resolved
Hide resolved
...tem.ComponentModel.Composition/src/System/ComponentModel/Composition/CompositionException.cs
Show resolved
Hide resolved
kumarravik78c
approved these changes
Apr 24, 2025
This was referenced Apr 24, 2025
tarekgh
approved these changes
Apr 24, 2025
carlossanlop
approved these changes
Apr 24, 2025
|
/backport to release/10.0-preview4 |
|
Started backporting to release/10.0-preview4: https://github.com/dotnet/runtime/actions/runs/14652863963 |
|
Ooops wrong port PR. @ericstj please ignore the backport. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were all flagged by internal compliance tooling. None of these seem to create functional issues, but it's easier to clean them up then suppress the compliance tool diagnostics.