[release/8.0-staging] Handle OSSL 3.4 change to SAN:othername formatting #115367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Backport to accommodate the change in SAN otherName formatting introduced by OpenSSL 3.4.
- Add detection for OpenSSL 3.4 in
PlatformDetection - Update the test for Subject Alternative Name formatting to handle the new OpenSSL 3.4 output
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Security.Cryptography/tests/AsnEncodedDataTests.cs | Add IsOpenSsl3_4 flag and adjust expected SAN formatting |
| src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs | Introduce IsOpenSsl3_4, refactor OpenSSL version checks |
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
|
Why didn't this backport cleanly? Because in 9.0 we renamed |
This was referenced May 7, 2025
bartonjs
approved these changes
May 7, 2025
|
Test-only change, no servicing review required. |
bartonjs
approved these changes
May 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #111820 to release/8.0-staging
/cc @vcsjones @bartonjs
Customer Impact
This is a test-only change to react to a change in OpenSSL 3.4 that is starting to appear in our CI pipelines. OpenSSL 3.4 formats a UPN in an otherName SAN differently.
Regression
Reacting to an upstream change in OpenSSL 3.4 that was introduced here openssl/openssl@de8861a
Testing
Existing tests caught the change. Tests pass after conditionally handling the OpenSSL 3.4 change, so that tests will continue to pass on older OpenSSL versions, too.
Risk
Low. Test only change.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.