Skip to content

[release/9.0-staging] Add support for more libicu versions #115376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

NikolaMilosavljevic
Copy link
Member

Fixes: #115274

Debian Trixie package repository was updated to include just libicu76. We require libicu72.

Besides version 76, this PR also adds versions 77 and 78, to limit the need to change this file often.

@Copilot Copilot AI review requested due to automatic review settings May 7, 2025 18:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for additional libicu versions to accommodate updates in the Debian Trixie repository while preserving compatibility with the required libicu72.

  • Added versions 78, 77, and 76 to the KnownLibIcuVersion list
  • Adjusted the dependency list in dotnet-runtime-deps-debian.proj to reflect these new versions

@NikolaMilosavljevic NikolaMilosavljevic added the Servicing-consider Issue for next servicing release review label May 7, 2025
@NikolaMilosavljevic NikolaMilosavljevic changed the title Add support for more libicu versions [release/9.0-staging] Add support for more libicu versions May 7, 2025
@jozkee
Copy link
Member

jozkee commented May 7, 2025

@NikolaMilosavljevic friendly reminder that code complete is on Monday May 12th (2:00 PM Pacific) for the June Release. If you'd like to get this change included in that release, please get a Tactics approval and merge this PR before that.

@NikolaMilosavljevic
Copy link
Member Author

This was approved for servicing - updating the label.

@NikolaMilosavljevic NikolaMilosavljevic added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 8, 2025
@NikolaMilosavljevic NikolaMilosavljevic merged commit 7a98cb9 into dotnet:release/9.0-staging May 8, 2025
79 of 82 checks passed
@NikolaMilosavljevic NikolaMilosavljevic added this to the 9.0.x milestone May 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy