Skip to content

[8.0] Fix line endings #115414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

[8.0] Fix line endings #115414

merged 1 commit into from
May 9, 2025

Conversation

richlander
Copy link
Member

Same as #115413.

Before:

$ git ls-files --eol | grep '\.cs' | grep crlf
i/crlf  w/crlf  attr/text=auto          src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/AssemblyInfo.cs
i/crlf  w/crlf  attr/text=auto          src/mono/wasm/debugger/tests/debugger-test-with-colon-in-source-name/debugger-test-with-colon-in-source-name.csproj

After:

$ git ls-files --eol | grep '\.cs' | grep crlf
$

@Copilot Copilot AI review requested due to automatic review settings May 8, 2025 22:31
@richlander richlander requested review from thaystg and radical as code owners May 8, 2025 22:31
Copilot
Copilot AI reviewed May 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR normalizes the line endings in C# source files by converting CRLF endings to LF, ensuring consistency across the codebase.

  • Removed CRLF line endings in the .csproj file.
  • Removed CRLF line endings in the AssemblyInfo.cs file.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/mono/wasm/debugger/tests/debugger-test-with-colon-in-source-name/debugger-test-with-colon-in-source-name.csproj Normalizes line endings, with no functional changes.
src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/AssemblyInfo.cs Normalizes line endings and preserves existing comments and code.

@carlossanlop carlossanlop requested a review from a team May 9, 2025 18:43
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@carlossanlop
Copy link
Contributor

Do we have an equivalent PR for main? If not, do you see the same issue in main?

@richlander
Copy link
Member Author

This is the change for main: #114171

jkotas
jkotas approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell mode

@jkotas jkotas added the Servicing-approved Approved for servicing release label May 9, 2025
@jkotas jkotas merged commit 2c39632 into dotnet:release/8.0-staging May 9, 2025
20 of 22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@jkotas jkotas jkotas approved these changes

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

@radical radical Awaiting requested review from radical radical is a code owner

Assignees

@richlander richlander

Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
Runtime Infra
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richlander @carlossanlop @jkotas
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy