Remove interactive special case for logger verbosity in `dotnet run` #47389

baronfel · 2025-03-08T19:16:28Z

This lights up Terminal Logger support in dotnet run again, using the new factory function.

This also changes the verbosity override in anticipation of MSBuild identifying and always printing auth messages.

My initial version of this applied the verbosity by splatting it as an argument along with the other loose MSBuildArgs. This was hard to track. So I've also added Verbosity tracking to MSBuildArgs so we can set it with less string-munging. Here's the before-and-after of that change:

The first dotnet run I wasn't able to set quiet easily, so minimal kept getting applied, overwriting my quiet setting.
The second dotnet run is after I was able to track the Verbosity setting for MSBuild, and ensure we only sent one. The Building... is because this project did opt into building messages in its launchsettings.json.

Part of dotnet/sdk#47602 ### Context With `NuGetInteractive=true` being passed in more scenarios as of dotnet/sdk#47226, the default verbosity for `dotnet run` is now `minimal` for user-present scenarios - that's gross. ### Changes Made Broadly what I'm trying to do here is not require passing `-v m` to loggers to get the authentication-related messages. Right now `dotnet run` does this and it's quite noisy compared to previous behavior. This changed because recently I made the SDK start passing `--interactive` when the user is at the keyboard (similar logic to Terminal Logger's own enablement), and `dotnet run` has logic to force verbosity to minimal when that happens so that the auth messages print where a user can see them. I kind of think of auth messages as messages that we should write regardless of verbosity (like errors are), so this is a step down that path for TL. This change ensures that auth messages are always written in the TL experience, as immediate messages. If this is accepted, then the SDK could remove the [special case it currently has](dotnet/sdk#47389). ### Testing Updated snapshot baselines, manual testing. ### Notes

Copilot

Pull Request Overview

This PR centralizes verbosity handling by moving VerbosityOptions into the Cli.Utils library, extending MSBuildArgs to carry verbosity state, and simplifying the dotnet run logger setup to use a single factory function.

Add Verbosity property and related clone methods to MSBuildArgs and update AnalyzeMSBuildArguments to capture it.
Remove ad-hoc interactive verbosity logic in RunCommand, replacing it with SetupSilentBuildArgs and a unified MakeTerminalLogger call.
Update all command parsers and tests to use the new Utils.VerbosityOptions and propagate the verbosity option through AnalyzeMSBuildArguments.

Reviewed Changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.

Show a summary per file

File or Group	Description
test/dotnet.Tests/CommandTests/Tool/Update/UpdateToolParserTests.cs (and similar *ParserTests.cs files)	Swapped `result.GetValue<T>` calls for `GetRequiredValue` where appropriate.
test/dotnet.Tests/CommandTests/MSBuild/GivenDotnetRunInvocation.cs	Added `RunCommandParser.VerbosityOption` to the `AnalyzeMSBuildArguments` call.
test/Microsoft.DotNet.Tools.Tests.ComponentMocks/ToolPackageDownloaderMock2.cs	Updated overrides to use fully-qualified `Cli.Utils.VerbosityOptions`.
test/Microsoft.DotNet.PackageInstall.Tests/…ToolPackageInstallerNugetCacheTests.cs	Added `using Microsoft.DotNet.Cli.Utils;` for new verbosity enum.
src/Cli/dotnet/CommonOptions.cs & CommonOptionsExtensions.cs	Removed inline `VerbosityOptions` enum and updated imports to Utils.
src/Cli/Microsoft.DotNet.Cli.Utils/VerbosityOptions.cs & MSBuildArgs.cs & MSBuildForwardingAppWithoutLogging.cs	Introduced `VerbosityOptions` enum, added verbosity support to `MSBuildArgs`, and emitted `--verbosity` in forwarding.
src/Cli/dotnet/Commands/**	Updated all parsers and commands to use `Utils.VerbosityOptions` and pass the verbosity option to `AnalyzeMSBuildArguments`.

Comments suppressed due to low confidence (3)

src/Cli/dotnet/Commands/Run/RunCommand.cs:415

[nitpick] The variable name thing is unclear—consider renaming it to something more descriptive like terminalLogger or logger.

        var thing = TerminalLogger.CreateTerminalOrConsoleLogger([$"--verbosity:{msbuildVerbosity}", ..buildArgs.OtherMSBuildArgs]);

src/Cli/dotnet/Commands/Run/RunCommand.cs:316

[nitpick] Consider adding unit tests to verify that dotnet run correctly includes the --verbosity flag in MSBuildArgs for both default and explicit verbosity levels, ensuring SetupSilentBuildArgs and MakeTerminalLogger behave as intended.

    private MSBuildArgs SetupSilentBuildArgs(MSBuildArgs msbuildArgs)

test/Microsoft.DotNet.Tools.Tests.ComponentMocks/ToolPackageDownloaderMock2.cs:59

The namespace qualifier Cli.Utils.VerbosityOptions may not resolve correctly; ensure you either add using Microsoft.DotNet.Cli.Utils; or fully qualify it as Microsoft.DotNet.Cli.Utils.VerbosityOptions.

        protected override void CreateAssetFile(PackageId packageId, NuGetVersion version, DirectoryPath packagesRootPath, string assetFilePath, string runtimeJsonGraph, Cli.Utils.VerbosityOptions verbosity, string? targetFramework = null)

src/Cli/Microsoft.DotNet.Cli.Utils/MSBuildForwardingAppWithoutLogging.cs

src/Cli/Microsoft.DotNet.Cli.Utils/VerbosityOptions.cs

jjonescz · 2025-07-11T07:51:30Z

src/Cli/Microsoft.DotNet.Cli.Utils/VerbosityOptions.cs

+    quiet,
+    q,
+    minimal,
+    m,
+    normal,
+    n,
+    detailed,
+    d,
+    diagnostic,
+    diag


Consider if we could make the equivalent enum items correspond to a single value like:

Suggested change

quiet,

q,

minimal,

m,

normal,

n,

detailed,

d,

diagnostic,

diag

quiet,

q = quiet,

minimal,

m = minimal,

normal,

n = normal,

detailed,

d = detailed,

diagnostic,

diag = diagnostic,

Which would make tests like verbosity == VerbosityOptions.quiet simpler (no need to check also for VerbosityOptions.q.

I do agree with you, but I actually want to rewrite this enum entirely (I have a WIP branch) and handle that as a separate change.

jjonescz · 2025-07-11T07:53:13Z

src/Cli/dotnet/Commands/Run/RunCommand.cs

            List<ILogger> loggersForBuild = [
-                MakeTerminalLogger(verbosity)
+                TerminalLogger.CreateTerminalOrConsoleLogger([$"--verbosity:{LoggerVerbosity.Quiet.ToString().ToLowerInvariant()}", ..buildArgs.OtherMSBuildArgs])


It feels like there could be a shared utility function for this common pattern - creating TerminalLogger from LoggerVerbosity and OtherMSBuildArgs

I think you're right - the Testing team especially may like that. @Evangelink?

I actually meant only in this repo, to share the code since I saw it repeating several times.

I know - the test team has a lot of similar stuff to run in the test command in this repo :)

cc @dotnet/dotnet-testing

… it in run command if necessary

…er to the last-provided one

ghost added Area-CLI untriaged Request triage from a team member labels Mar 8, 2025

build-analysis bot mentioned this pull request Mar 8, 2025

restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879

Open

3 tasks

baronfel mentioned this pull request Mar 20, 2025

always print auth messages in TL, regardless of verbosity dotnet/msbuild#11551

Merged

baronfel mentioned this pull request Jul 10, 2025

Make --interactive not require boosting MSBuild logger verbosity to minimal from quiet #47602

Closed

baronfel closed this Jul 10, 2025

baronfel force-pushed the remove-interactive-special-case branch from b47469f to 301f9e9 Compare July 10, 2025 17:41

baronfel changed the title ~~Remove interactive special case~~ Remove interactive special case for logger verbosity in dotnet run Jul 10, 2025

baronfel reopened this Jul 10, 2025

baronfel marked this pull request as ready for review July 11, 2025 01:06

Copilot AI review requested due to automatic review settings July 11, 2025 01:06

Copilot AI reviewed Jul 11, 2025

View reviewed changes

build-analysis bot mentioned this pull request Jul 11, 2025

dotnet-watch tests failing #40006

Open

jjonescz approved these changes Jul 11, 2025

View reviewed changes

baronfel requested review from tmat and a team as code owners July 11, 2025 19:18

baronfel force-pushed the remove-interactive-special-case branch from 611318e to 820b90f Compare July 11, 2025 20:52

This was referenced Jul 12, 2025

Containers integration tests are flaky when the network fails to load the registry #49502

Open

Template engine tests hitting known parallelism issue in GetVisualStudioInstances #44878

Open

baronfel added 8 commits July 12, 2025 07:42

re-enable TL for run scenarios

3670a9b

add verbosity modeling to MSBuildArgs so that we can safely overwrite…

dcb9b88

… it in run command if necessary

Ensure that the 'build' to get the run arguments is silent

d642b3c

ensure that file-based apps get the same verbosity-handling logic

b92ce44

allow for verbosity tokens to be provided multiple times and auto-def…

9b63415

…er to the last-provided one

more normalization of verbosity handling

c4379fe

fix baselines for completions tests now that verbosity is modeled better

7b8ba4b

more test baselines

9be9a4f

baronfel force-pushed the remove-interactive-special-case branch from 3199459 to 9be9a4f Compare July 12, 2025 12:42

baronfel merged commit f9748c8 into dotnet:main Jul 13, 2025
27 checks passed

baronfel deleted the remove-interactive-special-case branch July 13, 2025 19:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove interactive special case for logger verbosity in `dotnet run` #47389

Remove interactive special case for logger verbosity in `dotnet run` #47389

Uh oh!

baronfel commented Mar 8, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

jjonescz Jul 11, 2025

Uh oh!

baronfel Jul 11, 2025

Uh oh!

jjonescz Jul 11, 2025

Uh oh!

baronfel Jul 11, 2025

Uh oh!

jjonescz Jul 11, 2025

Uh oh!

baronfel Jul 11, 2025

Uh oh!

Evangelink Jul 11, 2025

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Remove interactive special case for logger verbosity in dotnet run #47389

Remove interactive special case for logger verbosity in dotnet run #47389

Uh oh!

Conversation

baronfel commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

jjonescz Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

baronfel Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

jjonescz Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

baronfel Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

jjonescz Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

baronfel Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Evangelink Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Remove interactive special case for logger verbosity in `dotnet run` #47389

Remove interactive special case for logger verbosity in `dotnet run` #47389

baronfel commented Mar 8, 2025 •

edited

Loading