Updated to Roslyn 2.6.0 #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seesharper
approved these changes
Dec 9, 2017
| @@ -31,7 +31,7 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Scripting" Version="2.4.0" /> | |||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Scripting" Version="2.6.0" /> | |||
| <PackageReference Include="Microsoft.Extensions.DependencyModel" Version="2.0.0" /> | |||
There was a problem hiding this comment.
Should we bump this one too?
It's available as 2.0.3 from NuGet now
https://www.nuget.org/packages/Microsoft.Extensions.DependencyModel/
seesharper
reviewed
Dec 9, 2017
| @@ -36,12 +36,6 @@ public class ScriptCompiler | |||
|
|
|||
| static ScriptCompiler() | |||
| { | |||
| // reset default scripting mode to latest language version to enable C# 7.1 features | |||
There was a problem hiding this comment.
Always good to get rid of some reflection hacks 👍
seesharper
approved these changes
Dec 9, 2017
seesharper
reviewed
Dec 9, 2017
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <Description>A cross platform library allowing you to run C# (CSX) scripts from a project.json dependency definition file and with support for debugging. Based on Roslyn.</Description> | |||
| <VersionPrefix>0.16.0</VersionPrefix> | |||
| <VersionPrefix>0.17.0</VersionPrefix> | |||
There was a problem hiding this comment.
yeah, we just go straight to 0.17.0 👍
seesharper
reviewed
Dec 9, 2017
| @@ -24,7 +24,7 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.Extensions.DependencyModel" Version="2.0.0" /> | |||
| <PackageReference Include="Microsoft.Extensions.DependencyModel" Version="2.0.3" /> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use C# 7.2 and remove some reflection.
Also, we could release this straight away as 0.17.0 including the recent bug fixes, or we release 0.16.1 first.