Feature/218 #219
Merged
Feature/218 #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
reviewed
Jan 9, 2018
src/Dotnet.Script.Core/Scaffolder.cs
Outdated
| @@ -35,7 +36,13 @@ public void InitializerFolder() | |||
| WriteFile(pathToOmniSharpJson, omniSharpFileTemplate); | |||
| } | |||
|
|
|||
| CreateNewScriptFile("helloworld.csx"); | |||
| if (Directory.GetFiles(currentDirectory, "*.csx", SearchOption.AllDirectories).Any() | |||
There was a problem hiding this comment.
is the depth-scan by design? I think we don't need to scan all subfolders, just the current one?
There was a problem hiding this comment.
Agreed. Top level should be enough 👍
filipw
reviewed
Jan 9, 2018
src/Dotnet.Script/Program.cs
Outdated
| @@ -88,10 +88,11 @@ private static int Wain(string[] args) | |||
| app.Command("init", c => | |||
| { | |||
| c.Description = "Creates a sample script along with the launch.json file needed to launch and debug the script."; | |||
| var fileName = c.Argument("filename", "The name of the sample script file to be created during initialization."); | |||
There was a problem hiding this comment.
we can add info that it's optional
|
@filipw Are we good here ? 😃 |
|
sorry I forgot :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing a custom filename during initialization.
This create a initialized folder with a script file named
custom.csxThis will now create a file named
main.csxinstead of the oldHelloWorld.csxfile.