Skip to content

Fix skipped shell-related tests in agent package #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhouston opened this issue Mar 25, 2025 · 0 comments
Open

Fix skipped shell-related tests in agent package #381

bhouston opened this issue Mar 25, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@bhouston
Copy link
Member

Description

Several tests in the packages/agent/src/tools/shell directory have been temporarily skipped due to issues with the test setup. These tests need to be revisited and fixed to ensure proper test coverage.

Affected files

  • packages/agent/src/tools/shell/shellStart.test.ts
  • packages/agent/src/tools/shell/shellStartFix.test.ts
  • packages/agent/src/tools/shell/shellStartBug.test.ts
  • packages/agent/src/tools/shell/shellTrackerIntegration.test.ts

Current workaround

The core functionality of the shell tools has been fixed to properly handle async mode when timeout=0 is specified. The tests have been skipped with appropriate TODO comments to indicate that they need to be fixed in a future update.

Suggested approach

  1. Review the mock setup for each test file
  2. Ensure the mocks properly capture the async behavior
  3. Update the tests to match the current implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy