Fix memory usage estimation for ELSER models #131630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @jan-elastic, I've created a changelog YAML for you. |
jan-elastic
commented
Jul 21, 2025
| @@ -96,7 +99,7 @@ boolean hasEverBeenAllocated() { | |||
|
|
|||
| public long estimateMemoryUsageBytes(int allocations) { | |||
| return StartTrainedModelDeploymentAction.estimateMemoryUsageBytes( | |||
| deploymentId, | |||
| modelId, | |||
There was a problem hiding this comment.
These are the important changes: passing the model ID instead of the deployment ID to the memory estimator.
If the deployment ID is passed, the method isElserV1Or2Model doesn't work, because it's passed .elser-2-elasticsearch or my-elser, which doesn't start with .elser_model_2.
38afae6 to
874149d
Compare
jan-elastic
added a commit
to jan-elastic/elasticsearch
that referenced
this pull request
Jul 22, 2025
* Pass model ID instead of deployment ID to memory estimator * Update docs/changelog/131630.yaml
💔 Backport failed
You can use sqren/backport to manually backport by running |
jan-elastic
added a commit
to jan-elastic/elasticsearch
that referenced
this pull request
Jul 22, 2025
* Pass model ID instead of deployment ID to memory estimator * Update docs/changelog/131630.yaml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 22, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.