Skip to content

Fix unresolved symbol in standalone debug build. #24680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vchigrin
Copy link

Ensure WASM binaries, produced in standalone debug mode, does not require __throw_exception_with_stack_trace function. In non-standalone mode it implemented in JS.

@vchigrin
Copy link
Author

Guess new behavior is desirable based on this reply
#19150 (comment)
particluary, sentence
"That shouldn't be emitted in standalone mode, so we should add an if to remove that. "

@sbc100
Copy link
Collaborator

sbc100 commented Jul 10, 2025

Perhaps we could add a test for this?

Perhaps you could update the existing test_f_exception in test_other.py it looks like it already has a standalone version of that test

@vchigrin
Copy link
Author

vchigrin commented Jul 11, 2025

Added a test - I found that separate test for this scenario looks better then integrating it into test_f_exception.
Checked that new test fails without first commit and passes with it.

@vchigrin vchigrin force-pushed the fix-standalone-debug-build branch from 730e1ef to 7b4831b Compare July 11, 2025 14:56
@sbc100 sbc100 enabled auto-merge (squash) July 11, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy