Skip to content

FIX StaticRequestHandler crashes when cache_header is null #7609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2020
Merged

FIX StaticRequestHandler crashes when cache_header is null #7609

merged 1 commit into from
Sep 22, 2020

Conversation

The-MEO
Copy link
Contributor

@The-MEO The-MEO commented Sep 22, 2020

In the StaticRequestHandler method, exception 28 (LoadProhibitedCause) occurs when debugging with the DEBUG_ESP_CORE option and if the default parameter null is used for cache_header.

In this commit, the pointer is checked for null before output.

d-a-v
d-a-v approved these changes Sep 22, 2020
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@d-a-v d-a-v merged commit 3cbf303 into esp8266:master Sep 22, 2020
@Jason2866 Jason2866 mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@The-MEO @d-a-v
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy