Fix eboot crash with exception 28. ets_printf() should take pointer argument. #7666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlephilhower
requested changes
Oct 21, 2020
|
The crash only happens when ACTION_COPY_RAW is called as part of an OTA firmware update. It breaks OTA updates and leaves the esp8266 in an infinite reset loop until it is power cycled, at which point it reverts to the old firware. |
d-a-v
reviewed
Oct 21, 2020
earlephilhower
requested changes
Oct 21, 2020
earlephilhower
approved these changes
Oct 21, 2020
d-a-v
approved these changes
Oct 21, 2020
Jason2866
added a commit
to Jason2866/Arduino
that referenced
this pull request
Oct 23, 2020
Jason2866
added a commit
to Jason2866/Arduino
that referenced
this pull request
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest update to eboot was trying to pass 32bit string literals as their own pointer to ets_printf(). This caused eboot to crash with exception 28 on any operation that used ets_printf().