Skip to content

Add setClientTimeout() to ESP8266HTTPUpdate #8740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 6, 2022
+5 −8
Merged

Add setClientTimeout() to ESP8266HTTPUpdate #8740

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
80c659c
defined new method setClientTimeout
DarioGHub Dec 4, 2022
65aa0c3
declared new member setClientTimeout()
DarioGHub Dec 4, 2022
e31ce32
added call to new method setClientTimeout
DarioGHub Dec 4, 2022
6ef16f3
removed a few spaces to pass clang format test
DarioGHub Dec 4, 2022
5acecaf
Update libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.h
mcspr Dec 6, 2022
1f6ec6d
Update libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.cpp
mcspr Dec 6, 2022
e2756b7
Merge branch 'master' into dwb_ESP8266HTTPUpdate
mcspr Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
defined new method setClientTimeout 
Alternative to destroying auto created object ESPhttpUpdate, then recreating it with the constructor that supported a timeout
  • Loading branch information
@DarioGHub
DarioGHub authored Dec 4, 2022
commit 80c659c3bde0128bc108c5b4c608d49d01255969
9 changes: 9 additions & 0 deletions libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,15 @@ void ESP8266HTTPUpdate::setAuthorization(const String &auth)
_auth = auth;
}

/**
* set the Timeout for the http request
* @param httpClientTimeout const int& millis
*/
void ESP8266HTTPUpdate::setClientTimeout(const int &httpClientTimeout)
{
_httpClientTimeout = httpClientTimeout;
}

HTTPUpdateResult ESP8266HTTPUpdate::update(WiFiClient& client, const String& url, const String& currentVersion)
{
HTTPClient http;
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy