chore: Typescript: Rewrite Configs #21763
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 24395c4.
There was a problem hiding this comment.
Hey @Maschga - I've reviewed your changes - here's some feedback:
- In
.storybook/preview.tsyou’ve declaredconst preview: Preview = {}but haven’t imported thePreviewtype—addimport type { Preview } from '@storybook/vue3';. - Now that your configs are in TypeScript, make sure your CLI scripts (Storybook, Jest, Prettier) are updated to load the
.tsfiles (e.g. via jiti or ts-node) and consider movingjitiinto devDependencies since it’s only needed at build/test time.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #21723
Configsto TypescriptNOTE:
.prettierrc.jssee BUG: Does not supportprettier.config.ts, recently added in Prettierv3.5.0prettier/prettier-vscode#3623