[doctor] check for @types/react-native on 48+ (and other things you shouldn't install directly) #4731
Conversation
| { | ||
| packageName: 'npm', | ||
| ...shouldBeInstalledGloballyItem, | ||
| }, | ||
| { | ||
| packageName: 'yarn', | ||
| ...shouldBeInstalledGloballyItem, | ||
| }, |
There was a problem hiding this comment.
I'm not sure why these are on this list, but if there are issues adding a local version of the package manager, we might also need to add pnpm.
There was a problem hiding this comment.
It was based on this conversation here: https://exponent-internal.slack.com/archives/CP8BDK9F1/p1682665047400689
At this point, it's probably 97% of a Doctor-meta-check. I did see another case recently where npm was in package.json pinned to an old version that broke npm why, so a bunch of Doctor checks bailed.
The best I can tell, it's mostly harmless, but also entirely unnecessary, and very occasionally not harmless. I'll add pnpm for now, but, based on the above, I could also see restricting it to just npm, since that's the only one I've ever seen break anything.
Why
@types/react-nativeis now included withreact-native. Including the wrong/ old version of types could lead to... issues with types.How
This looks more complicated than it sounds. That's because I'm starting a refactor with bigger goals in mind :D. I could have wedged this check as a conditional into the existing
PackageJsonCheck, but the SDK filter happens for each check file, so I'd either duplicate that, or.......introduce a
DoctorMultiCheckthat can filter by SDK by each individual item in a check, but, at least for now, without breaking theDoctorCheckinterface. Combined with extracting the precise message for each package, this makes it easier to define additional checks of the same type as configuration. This use case is very simplistic, but the pattern would really sing once we have, say, a singleDeepDependencyCheckwith all those defined as configuration, running 100% in parallel, etc.Bonus
Added the check for yarn/ npm direct installs because onto this because it's just another item in the list (and noticed some issues in the wild with it again).
Test Plan
types/react-native
npm:
Tagging @byCedric to at least confirm that the test for
@types/react-nativeitself is accurate (I couldn't find much info about this change after you mentioned it).