This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[image-utils] [ENG-9956] add a function to check whether a PNG is valid #4761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to check whether the app icon and splash screen images in the codebase are invalid before pre-building so we could show the user an error message and fail the build. ENG-9956.
How
Added an
getPngInfo
function returns the PNG data if a valid PNG is found, and throws otherwise.Intended usage:
Test Plan
Added
packages/image-utils/src/__tests__/image-test.ts
to verify for different file types.