Set up test to validate refactor of XHR, FileReader and WebSocket classes to use the built-in EventTarget implementation #48930
+6,046
−1,408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 25, 2025
…sses to use the built-in EventTarget implementation (facebook#48930) Summary: Pull Request resolved: facebook#48930 Changelog: [internal] This creates new versions of `XMLHttpRequest`, `FileReader` and `WebSocket` that extend the new built-in `EventTarget` implementation, instead of the implementation from the `event-target-shim` package. It also sets up a test to choose between the 2 implementations at runtime to verify correctness and performance. This doesn't use the RN feature flags infra because we use this flag very early on startup, before we have a chance to set overrides. We could use a native feature flag instead but it'd slow down the rollout of the test. Differential Revision: D68625226
565b91a to
b189e4e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 25, 2025
…sses to use the built-in EventTarget implementation (facebook#48930) Summary: Pull Request resolved: facebook#48930 Changelog: [internal] This creates new versions of `XMLHttpRequest`, `FileReader` and `WebSocket` that extend the new built-in `EventTarget` implementation, instead of the implementation from the `event-target-shim` package. It also sets up a test to choose between the 2 implementations at runtime to verify correctness and performance. This doesn't use the RN feature flags infra because we use this flag very early on startup, before we have a chance to set overrides. We could use a native feature flag instead but it'd slow down the rollout of the test. Differential Revision: D68625226
b189e4e to
fafd524
Compare
Differential Revision: D67738145
Differential Revision: D67750677
Differential Revision: D67758702
…nlyNode Differential Revision: D67758408
Differential Revision: D67751821
Differential Revision: D67830012
…global scope Differential Revision: D68672215
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 27, 2025
…sses to use the built-in EventTarget implementation (facebook#48930) Summary: Pull Request resolved: facebook#48930 Changelog: [internal] This creates new versions of `XMLHttpRequest`, `FileReader` and `WebSocket` that extend the new built-in `EventTarget` implementation, instead of the implementation from the `event-target-shim` package. It also sets up a test to choose between the 2 implementations at runtime to verify correctness and performance. This doesn't use the RN feature flags infra because we use this flag very early on startup, before we have a chance to set overrides. We could use a native feature flag instead but it'd slow down the rollout of the test. Differential Revision: D68625226
fafd524 to
8f9f15a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
Differential Revision: D67839560
Differential Revision: D67804060
…in XHR Differential Revision: D68625224
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 27, 2025
…sses to use the built-in EventTarget implementation (facebook#48930) Summary: Pull Request resolved: facebook#48930 Changelog: [internal] This creates new versions of `XMLHttpRequest`, `FileReader` and `WebSocket` that extend the new built-in `EventTarget` implementation, instead of the implementation from the `event-target-shim` package. It also sets up a test to choose between the 2 implementations at runtime to verify correctness and performance. This doesn't use the RN feature flags infra because we use this flag very early on startup, before we have a chance to set overrides. We could use a native feature flag instead but it'd slow down the rollout of the test. Differential Revision: D68625226
8f9f15a to
1bdd302
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
…sses to use the built-in EventTarget implementation (facebook#48930) Summary: Pull Request resolved: facebook#48930 Changelog: [internal] This creates new versions of `XMLHttpRequest`, `FileReader` and `WebSocket` that extend the new built-in `EventTarget` implementation, instead of the implementation from the `event-target-shim` package. It also sets up a test to choose between the 2 implementations at runtime to verify correctness and performance. This doesn't use the RN feature flags infra because we use this flag very early on startup, before we have a chance to set overrides. We could use a native feature flag instead but it'd slow down the rollout of the test. Differential Revision: D68625226
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
1bdd302 to
218be6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This creates new versions of
XMLHttpRequest,FileReaderandWebSocketthat extend the new built-inEventTargetimplementation, instead of the implementation from theevent-target-shimpackage.It also sets up a test to choose between the 2 implementations at runtime to verify correctness and performance. This doesn't use the RN feature flags infra because we use this flag very early on startup, before we have a chance to set overrides. We could use a native feature flag instead but it'd slow down the rollout of the test.
Differential Revision: D68625226