Skip to content

🌐 Update Korean translation for docs/ko/docs/virtual-environments.md #13630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

sungchan1
Copy link

@sungchan1 sungchan1 commented Apr 21, 2025

Hello! 👋 This is my first contribution to FastAPI Korean translation 😊

I translated the docs/ko/docs/virtual-environments.md file into Korean.
Since it's a core topic in Python projects, I noticed it hasn't been localized yet, so I decided to help!

I tried to stay as close as possible to the original English format and meaning.

If there is any feedback, I’d be happy to update it right away.

감사합니다!

image

Before : https://fastapi.tiangolo.com/ko/virtual-environments/
After. : https://2d5c56b3.fastapitiangolo.pages.dev/ko/virtual-environments/

@github-actions github-actions bot added the lang-all Translations label Apr 21, 2025
Copy link
Contributor

@alejsdev alejsdev changed the title 🌐 Update Korean translation for docs/ko/docs/virtual-environments.md 🌐 Update Korean translation for docs/ko/docs/virtual-environments.md Apr 21, 2025
@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Apr 21, 2025
Copy link
Contributor

@sodaMelon
Copy link

sodaMelon commented Apr 23, 2025

hi @sungchan1
just saw your email asking me to review this PR
so I'll comment later (maybe...... in this evening!!!!)

안녕하세요 @sungchan1
이메일로 리뷰 부탁하신 것 방금확인했어요.
이따가 코멘트 드리겠습니다(오늘 저녁 예정!! 평일엔 제가 조금 바쁘네요;;; )

Copy link

@sodaMelon sodaMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

텍스트 양이 많아서 일단 여기서 한번 끊을게요!

@sodaMelon
Copy link

@sungchan1 finally i finished review.
there are too many comments.... but...maybe you can check all😅 (bc this doc is longer than others)
리뷰 마쳤습니다.
코멘트가 너무 많지만, 확인 잘부탁드립니다.😅 (이 문서 자체가 다른 문서보다 기네요..)

+) 전체적으로 문장이 자연스럽습니다. 잘해주셨어요! 단, 자연스럽게 번역하다보니 원문과 의미가 좀 멀어질 수 있는 것들을 체크해두었으니......... 현실에서 소리내어서 읽어보시고 자연스러운 쪽을 선택하세요.

sungchan1 and others added 2 commits April 25, 2025 18:04
- 읽었을 때, 어색한 단어, 조사 수정했습니다.
- Python에 기본 포함된 -> Python 표준 라이브러리 통일했습니다.
- 잘못 처리된 굵은 단어, `` 단어 수정했습니다.
- 소제목 통일 (~~하기 -> ~~)
  - 패키지 설치하기 -> 패키지 설치
  - `requirements.txt`에서 설치하기 -> `requirements.txt`에서 설치
- 해리 포터 예시 해석 추가
  - philosophers-stone -> 마법사의 돌(philosophers-stone)
  - prisoner-of-azkaban -> 아즈카반의 죄수(prisoner-of-azkaban)
Copy link
Contributor

- 오타 수정했습니다
  동일하장 작동할 수 있도록 보 -> 동일하게 작동할 수 있도록 보장
Copy link
Contributor

Copy link

@sodaMelon sodaMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
i left just 1 request comment for my mistake. 😅
if you modify it, and I'll approve!

잘해주셨습니다~~
제가 실수한 거에 대해서 코멘트 남겨뒀어요! ㅋㅋ ㅠㅠㅠ
그거만 반영해주시면 approve 드릴게요~~ 고생하셨습니다!!!

sungchan1 and others added 2 commits April 29, 2025 15:27
Copy link
Contributor

Copy link
Contributor

@Zerohertz Zerohertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// warning | 경고

위와 같이 전체적으로 | {한국어} 주석이 필요할 것으로 보입니다 ㅎㅎ!

그 외에는 잘 번역해 주셔서 감사드립니다 ㅎㅎ
위 사항 수정 후 approve 하겠습니다.

Copy link
Contributor

github-actions bot commented May 5, 2025

📝 Docs preview for commit b0b58fe at: https://c59a3b34.fastapitiangolo.pages.dev

Modified Pages

Copy link
Contributor

github-actions bot commented May 5, 2025

📝 Docs preview for commit 1e807d0 at: https://40df1bcb.fastapitiangolo.pages.dev

Modified Pages

Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy