Skip to content

set min version py3.10, cleanup type annotations #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Conversation

kushalkolar
Copy link
Member

@kushalkolar kushalkolar commented Mar 31, 2024

closes #440

sets minimum python version and cleans up type annotations. Unions[X, Y] -> X | Y, and builtins ex: Dict[str, list] -> dic[str, list]

move generate_add_graphic_methods.py to new scripts dir out of source tree

Unfortunately the new X | Y annotations don't show up in the add_graphic methods since the autogeneration by inspect.signature returns them in the old form with Union, ah well.

@kushalkolar kushalkolar requested a review from clewis7 as a code owner March 31, 2024 07:56
@kushalkolar kushalkolar merged commit 2f49497 into main Mar 31, 2024
@kushalkolar kushalkolar deleted the drop-py39 branch March 31, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drop python3.9
1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy