-
Notifications
You must be signed in to change notification settings - Fork 53
Get nearest graphics #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get nearest graphics #519
Conversation
@clewis7 @apasarkar what about just skipping the edge method, using the bbox is actually useless for many real use cases like this where there is lots of overlap 🙃 |
This looks amazing!! I am okay with skipping edge. When I think about doing something like clicking a contour I would be clicking near the center... |
I think I'm going to make this a function in |
@clewis7 ready for review! |
if not all(isinstance(g, Graphic) for g in graphics): | ||
raise TypeError("all elements of `graphics` must be Graphic objects") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there also be a check for if all the graphics are in the same subplot? Or would that not make a difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We leave that to the user, so it's just a very simple function unaware of plot areas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See question...
closes #514
WIP, need to finish edge method
get_nearest-2024-06-17_00.35.24.mp4