-
Notifications
You must be signed in to change notification settings - Fork 53
add rectangular region selector #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d262570
start working on adding rectangle region selector
clewis7 d7f3148
rename selector tool
clewis7 d0a04e6
update line setting, remove origin
clewis7 8ddfc8a
fix selection feature
clewis7 c3e2cef
fix pick write issue
clewis7 db37714
rename file, fix line initialization
clewis7 f8b7f02
add fixed axis if given, make sure bounds enforced
clewis7 72defab
add methods for graphics
clewis7 3f068cf
get selected ixs and data for images
clewis7 dcc3774
add rectangle methods
clewis7 4b7e00d
better lower bound limit for collections
clewis7 4dda743
add vertices
clewis7 4ab552f
screen space instead of world space for vertices
clewis7 0a63cac
change vertices to square, change vertex color
clewis7 3e33aa5
fix selection for line collections
clewis7 74f0925
add example
clewis7 c466dab
update api docs, add example
clewis7 ad203b2
lint
clewis7 86b0d5d
update conf and api files
clewis7 4ffffa1
this file should be deleted
clewis7 4962838
requested changes, update with better example, more comments
clewis7 28f247b
fix offset when adding rectangle selector so fill events happen
clewis7 8e109b7
update api docs
clewis7 da90444
requested changes
clewis7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
from ._linear import LinearSelector | ||
from ._linear_region import LinearRegionSelector | ||
from ._polygon import PolygonSelector | ||
from ._rectangle_region import RectangleSelector | ||
|
||
|
||
__all__ = ["LinearSelector", "LinearRegionSelector"] | ||
__all__ = ["LinearSelector", "LinearRegionSelector", "RectangleSelector"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.