update screenshot #700
Merged
update screenshot #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clewis7 this should fix the current CI failure |
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/fix-screenshot |
|
I also changed the CI timeout from 10 mins to 15, for whatever reason it took llvmpipe etc. 7 mins to install. Maybe something changed on github actions 🤷♂️ . Anyways jobs usually finish in 5 mins, maybe stuff gets cached so if it hits a new machine or something it takes longer. |
Merged
|
idk what's taking so long with apt install on github actions lately, relaxed the timeout time to 25 mins 🤷♂️ |
|
wtf, so now all the jobs finished within 5mins?? Must be some caching things or apt servers were slow for some reason during those earlier runs |
clewis7
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my hunch is this is due to pygfx/pygfx#945
when
set_data()is used, it wouldn't immediately update the camera related stuff which is why the axes don't appear on the initial draw afterset_data(), as a user we don't notice it because that draw only lasts for a few milliseconds.