-
Notifications
You must be signed in to change notification settings - Fork 53
more event docs, make some things public #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3f16430
to
9999a56
Compare
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/docs-events-detailed |
@clewis7 replacing all hard-coded rst event info tables with list of dicts, more maintainable, easy to parse it into a table for docs. class VertexPositions(BufferManager):
property_name = "data"
event_info_spec = [
{
"dict key": "key",
"type": "slice, index (int) or numpy-like fancy index",
"description": "key at which vertex positions data were indexed/sliced"
},
{
"dict key": "value",
"type": "int | float | array-like",
"description": "new data values for points that were changed"
},
] I copy-pasted some code from here, it works: https://pablofernandez.tech/2019/03/21/turning-a-list-of-dicts-into-a-restructured-text-table/ |
Thoughts for making classes under graphics.features public:
|
I like keeping the name the same. I also like Aside from type annotations, when would a user need I like the explicit access of a |
Earlier we kinda came to the conclusion that anything which is use ~80% of the time should be a top level import, and event it's used for type annotations it's still very useful and events are used very often so I've made it a top level import. It's a pretty clean import so there aren't issues with doing this. |
@clewis7 should be gtg! summary of major changes other than those already mentioned above:
Tested all examples and they work! |
WIP
get_nearest_graphics()
with circlesutils.plot_helpers
graphics._features
public underfpl.graphics
, this allows the various features to be used by users for instance checks and similar purposes.FeatureEvent
->GraphicFeatureEvent
, make it a top level public import.graphics.Graphic
accessible publicly, also useful for instance checks etc.Subplot
accessible underfpl.Layouts