Improve hover color behavior for selectors #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/selector-color |
kushalkolar
approved these changes
Apr 15, 2025
|
Thanks! I also want to refactor it to use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #781
I noticed that the color of the selector was flickering during motion, as the mouse enters and exits the object. This PR freezes the color while
._moving, keeping track of color changes in a dict, and then applying that dict when the moving is done.Notice how the corner vertex becomes highlighted as the mouse is released after dragging the edge:
Screen.Recording.2025-04-15.at.11.29.22.mov