docstring and docs cleanup, other misc small things #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Caitlin Lewis <69729525+clewis7@users.noreply.github.com>
Co-authored-by: Caitlin Lewis <69729525+clewis7@users.noreply.github.com>
|
I'm going to add a test for figure name stuff |
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/old-renames |
|
@clewis7 ready for another look, better logic to check subplot_names size, tests for it, and updated add_ methods mixin |
clewis7
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed lots of instances where gridplot was still lingering to Figure. There is no such thing as "grid plot" anymore so changed those descriptions to "grid layout".
Some other docstring cleanup, reword some things to be better. Some better error messages in
Figure.__init__()removed "padding" kwarg for
add_linear_selector()methods since it's no longer required since we have inf lines 😄also fixes #818
@clewis7 ready for review