further changes and ideas

fastplotlib · clewis7 · Dec 12, 2022 · Dec 12, 2022 · Dec 14, 2022 · Dec 15, 2022
commit 68a89d7d26c28f86bba0c7c0d4c10377e046bf8f
diff --git a/fastplotlib/graphics/_base.py b/fastplotlib/graphics/_base.py
@@ -5,6 +5,7 @@
 from ..utils import get_colors
 from .features import GraphicFeature, DataFeature, ColorFeature, PresentFeature
 
+from abc import ABC, abstractmethod
 
 class Graphic:
     def __init__(
@@ -107,28 +108,35 @@ def __repr__(self):
 <<<<<<< HEAD
 =======
 
-class Interaction:
+class Interaction(ABC):
     # make them abstract properties
     @property
+    @abstractmethod
     def indices(self) -> Any:
         pass
 
     @indices.setter
+    @abstractmethod
     def indices(self, indices: Any):
         pass
 
     @property
+    @abstractmethod
     def features(self) -> List[str]:
         pass
 
+    @abstractmethod
     def _set_feature(self, name: str, new_data: Any, indices: Any):
         pass
 
+    @abstractmethod
     def link(self, event: str, feature: Any, feature_data: Any, target: Graphic, target_feature: Any, target_data: Any, indices_mapper: Any):
         # event occurs, causes change in feature of current graphic to data indices from pick_info,
         # also causes change in target graphic to target feature at target data with corresponding or mapped
         # indices based on the indice_mapper function
 
+        # events can be feature changes, when feature changes want to trigger an event
+
         # indice mapper takes in source features and maps to target features
         pass
 

diff --git a/fastplotlib/graphics/heatmap.py b/fastplotlib/graphics/heatmap.py
@@ -1,10 +1,15 @@
 import numpy as np
 import pygfx
 from typing import *
+
+from fastplotlib.graphics._base import Graphic
+
 from .image import ImageGraphic
 
 from ..utils import quick_min_max, get_cmap_texture
 
+from ._base import Interaction
+
 
 default_selection_options = {
     "mode": "single",
@@ -40,7 +45,22 @@ def __init__(
             self.callbacks = callbacks
 
 
-class HeatmapGraphic(ImageGraphic):
+class HeatmapGraphic(ImageGraphic, Interaction):
+    @property
+    def indices(self) -> Any:
+        pass
+
+    @property
+    def features(self) -> List[str]:
+        pass
+
+    def _set_feature(self, name: str, new_data: Any, indices: Any):
+        pass
+
+    def link(self, event: str, feature: Any, feature_data: Any, target: Graphic, target_feature: Any, target_data: Any,
+             indices_mapper: Any):
+        pass
+
     def __init__(
             self,
             data: np.ndarray,