Interactivity attempt 4 #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
okay, functionality is back to where it was before...can click on single contour and change color should now be ready to finish interactivity |
kushalkolar
reviewed
Dec 28, 2022
|
update: about to start working on line collection but made the changes you suggested to base and line graphics line graphic is single graphic so it normally wouldn't have indices, but I made sure that it would work if slice, int, etc. is passed into set_feature just in the event that it would happen reset_feature also works nicely when indices are included or not!! |
kushalkolar
reviewed
Dec 29, 2022
This was referenced Dec 30, 2022
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git hates me, feeling is mutual
implements #39
hopefully the last interactivity branch before it can be merged