Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test Podfile and eliminate unnecessary podspec dependencies #969

Merged
merged 9 commits into from
Jun 23, 2021
Merged

Fix test Podfile and eliminate unnecessary podspec dependencies #969

merged 9 commits into from
Jun 23, 2021

Conversation

morganchen12
Copy link
Contributor

Pull request to expose firebase/firebase-ios-sdk#8137.

To repro, cd samples/swift and run a pod install. The app target should fail to build with some linker errors:

Undefined symbols for architecture x86_64:
  "_FIRFacebookAuthProviderID", referenced from:
      +[FUIAuthBaseViewController providerLocalizedName:] in FUIAuthBaseViewController.o
  "_OBJC_CLASS_$_FIRApp", referenced from:
      objc-class-ref in FUIAuth.o
      objc-class-ref in FUIAuthStrings.o
  "_OBJC_CLASS_$_FIRAuth", referenced from:
      objc-class-ref in FUIAuth.o
  "_FIRAuthErrorUserInfoUpdatedCredentialKey", referenced from:
      ___95-[FUIAuth autoUpgradeAccountWithProviderUI:presentingViewController:credential:resultCallback:]_block_invoke in FUIAuth.o
  "_FIRTwitterAuthProviderID", referenced from:
      +[FUIAuthBaseViewController providerLocalizedName:] in FUIAuthBaseViewController.o
  "_FIRGoogleAuthProviderID", referenced from:
      +[FUIAuthBaseViewController providerLocalizedName:] in FUIAuthBaseViewController.o
  "_FIREmailAuthProviderID", referenced from:
      ___75-[FUIAccountSettingsOperation showVerifyDialogWithMessage:providerHandler:]_block_invoke in FUIAccountSettingsOperation.o
      ___67-[FUIAccountSettingsOperationDeleteAccount showDeleteAccountDialog]_block_invoke in FUIAccountSettingsOperationDeleteAccount.o
      -[FUIAccountSettingsViewController accountState] in FUIAccountSettingsViewController.o
      -[FUIAccountSettingsViewController updateTableStateLinkedAccountWithoutEmail] in FUIAccountSettingsViewController.o
      -[FUIAccountSettingsViewController updateTableStateLinkedAccountWithEmail] in FUIAccountSettingsViewController.o
      -[FUIAccountSettingsViewController updateTableStateLinkedAccountWithEmailPassword] in FUIAccountSettingsViewController.o
      +[FUIAuthBaseViewController providerLocalizedName:] in FUIAuthBaseViewController.o

@google-cla google-cla bot added the cla: yes label Jun 22, 2021
@morganchen12 morganchen12 mentioned this pull request Jun 22, 2021
Closed
@googlebot

This comment has been minimized.

Sign in to view
1 similar comment
@google-cla
Copy link

google-cla bot commented Jun 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@paulb777 paulb777 added cla: yes and removed cla: no labels Jun 23, 2021
@googlebot

This comment has been minimized.

Sign in to view
1 similar comment
@google-cla
Copy link

google-cla bot commented Jun 23, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jun 23, 2021
@paulb777
Copy link
Member

Podspecs should not rely upon transitive dependencies. Adding the missing direct dependencies fixes the build failure for me.

@googlebot

This comment has been minimized.

Sign in to view
1 similar comment
@google-cla
Copy link

google-cla bot commented Jun 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@paulb777 paulb777 added cla: yes and removed cla: no labels Jun 23, 2021
@googlebot

This comment has been minimized.

Sign in to view
1 similar comment
@google-cla
Copy link

google-cla bot commented Jun 23, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot

This comment has been minimized.

Sign in to view
1 similar comment
@google-cla
Copy link

google-cla bot commented Jun 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jun 23, 2021
@paulb777 paulb777 added cla: yes and removed cla: no labels Jun 23, 2021
@google-cla

This comment has been minimized.

Sign in to view
1 similar comment
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot

This comment has been minimized.

Sign in to view
1 similar comment
@google-cla
Copy link

google-cla bot commented Jun 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@paulb777 paulb777 added cla: yes and removed cla: no labels Jun 23, 2021
@googlebot

This comment has been minimized.

Sign in to view
1 similar comment
@google-cla
Copy link

google-cla bot commented Jun 23, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jun 23, 2021
@googlebot

This comment has been minimized.

Sign in to view
1 similar comment
@google-cla
Copy link

google-cla bot commented Jun 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@paulb777 paulb777 added cla: yes and removed cla: no labels Jun 23, 2021
@googlebot

This comment has been minimized.

Sign in to view
1 similar comment
@google-cla
Copy link

google-cla bot commented Jun 23, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@paulb777
Copy link
Member

@morganchen12 The issue seems to be the Podfile that replicates the FirebaseEmailAuthUI podspec not including the needed GoogleUtilities dependency.

I also simplified some of the dependencies in some of the podspecs

@paulb777 paulb777 changed the title Create linker errors Fix test Podfile and eliminate unnecessary podspec dependencies Jun 23, 2021
@morganchen12
Copy link
Contributor Author

Thanks!

@morganchen12 morganchen12 merged commit 8bcc0b1 into master Jun 23, 2021
@morganchen12 morganchen12 deleted the mc/repro branch June 23, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees

@morganchen12 morganchen12

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morganchen12 @googlebot @paulb777
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy