Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove __trigger #1150

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Remove __trigger #1150

merged 2 commits into from
Jun 24, 2022

Conversation

inlined
Copy link
Member

@inlined inlined commented Jun 17, 2022

Remove all __trigger annotations and all other things that are now unused.

@inlined inlined requested review from colerogers and taeold June 17, 2022 23:57
@taeold taeold added this to the v4 milestone Jun 24, 2022
@taeold taeold merged commit 4092d43 into inlined.refactor Jun 24, 2022
@taeold taeold deleted the inlined.drop-__trigger branch June 24, 2022 23:46
inlined added a commit that referenced this pull request Jun 26, 2022
* Remove __trigger

* Lint fixes
inlined added a commit that referenced this pull request Jun 27, 2022
* Divide everything into v1, v2, and common (unexported).

Did some refactoring, like putting `firebaseConfig` into common.
This means we have absolutely no dependencies on v1 in common or
v2. Some files are left at the root because they were modified
in other CLs that are outstanding and I want to linearize the
changes to minimize conflicts.

While working, I removed some legacy workarounds that should no
longer apply. For example, we no longer need to load fireaseConfig
from runtime config because all supported versions of the CLI
set the FIREBASE_CONFIG environment variable. This meant we
could remove all of setup.ts because all monkeypatches were for
outdated runtimes. Since there is no longer an environment
change between importing v1/index and a subpackage, I've gone
ahead and exported the providers for v1 to minimize customer
frustration with the v1 namespace.

* Fix dependency conflicts

* Lint fixes

* Remove __trigger (#1150)

* Remove __trigger

* Lint fixes

* Divide everything into v1, v2, and common (unexported).

Did some refactoring, like putting `firebaseConfig` into common.
This means we have absolutely no dependencies on v1 in common or
v2. Some files are left at the root because they were modified
in other CLs that are outstanding and I want to linearize the
changes to minimize conflicts.

While working, I removed some legacy workarounds that should no
longer apply. For example, we no longer need to load fireaseConfig
from runtime config because all supported versions of the CLI
set the FIREBASE_CONFIG environment variable. This meant we
could remove all of setup.ts because all monkeypatches were for
outdated runtimes. Since there is no longer an environment
change between importing v1/index and a subpackage, I've gone
ahead and exported the providers for v1 to minimize customer
frustration with the v1 namespace.

* Fix dependency conflicts

* Lint fixes

* Remove __trigger (#1150)

* Remove __trigger

* Lint fixes

* Move apps and utilities into common
@TheIronDev TheIronDev restored the inlined.drop-__trigger branch October 20, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy