Fix lint warnings.

firebase · Feb 23, 2019 · e6525d7 · e6525d7
1 parent c040b9c
commit e6525d7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/Firebase/Auth/Source/AuthProviders/OAuth/FIROAuthProvider.m b/Firebase/Auth/Source/AuthProviders/OAuth/FIROAuthProvider.m
@@ -277,8 +277,9 @@ - (void)getHeadFulLiteURLWithEventID:(NSString *)eventID
     NSString *URLString =
         [NSString stringWithFormat:kHeadfulLiteURLStringFormat, authDomain, argumentsString];
     if (completion) {
+      NSCharacterSet *set = [NSCharacterSet URLFragmentAllowedCharacterSet];
       completion([NSURL URLWithString:
-          [URLString stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]], nil);
+          [URLString stringByAddingPercentEncodingWithAllowedCharacters:set]], nil);
     }
   }];
 }

diff --git a/Firebase/Auth/Source/FIRAuth.m b/Firebase/Auth/Source/FIRAuth.m
@@ -468,10 +468,10 @@ - (void)fetchProvidersForEmail:(NSString *)email
 }
 
 
-#if TARGET_OS_IOS
 - (void)signInWithProvider:(id<FIRFederatedAuthProvider>)provider
                 UIDelegate:(nullable id<FIRAuthUIDelegate>)UIDelegate
                 completion:(nullable FIRAuthDataResultCallback)completion {
+#if TARGET_OS_IOS
   dispatch_async(FIRAuthGlobalWorkQueue(), ^{
     FIRAuthDataResultCallback decoratedCallback =
         [self signInFlowAuthDataResultCallbackByDecoratingCallback:completion];
@@ -487,8 +487,8 @@ - (void)signInWithProvider:(id<FIRFederatedAuthProvider>)provider
                                                callback:decoratedCallback];
     }];
   });
-}
 #endif  // TARGET_OS_IOS
+}
 
 - (void)fetchSignInMethodsForEmail:(nonnull NSString *)email
                         completion:(nullable FIRSignInMethodQueryCallback)completion {

diff --git a/Firebase/Auth/Source/FIRAuthWebUtils.m b/Firebase/Auth/Source/FIRAuthWebUtils.m
@@ -165,7 +165,7 @@ + (NSString *)stringByUnescapingFromURLArgument:(NSString *)argument {
                                 withString:@" "
                                    options:NSLiteralSearch
                                      range:NSMakeRange(0, [resultString length])];
-  return [resultString stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
+  return [resultString stringByRemovingPercentEncoding];
 }
 
 @end