-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK 7.5.0 crash when client calls iOS Vision framework #7400
Comments
VNGenerateAttentionBasedSaliencyImageRequest()
Hey @hingarn, apologies for this. We're looking into the issue but for now please downgrade to 7.4.0. |
Hey @hingarn - I wasn't able to reproduce this. I was wondering if you could tell me a little more about your setup, in particular:
Any other information that's specific to your environment would be hugely appreciated. |
Hey @samedson, here is the info.
Our environment is straightforward. We do not do any custom setup. We do use Shake SDK for bug reporting, which does method swizzling. Please let me know if I can provide you any additional details about the setup. |
My reproduction case still isn't crashing on an M1 machine, so here's the quickstart project that I'm using to try and reproduce the issue with calls to the Vision API. Would someone here be able to try out this project and see if it reproduces the behavior on their machine, or tweak it such that it does? Xcode Project Quickstart using the Vision API It seems like common factors are:
|
I am seeing this issue on a non-Apple Silicon Mac, in the simulator. I’ll give that sample project a try and see if I can reproduce it. |
@samedson created a PR that reproduces the issue for me: samedson/issues#1 |
I should be clear the only framework we're using in our application is Crashlytics (and any dependencies it may be using.) |
Thank you @chrisvasselli for the repro case 👍 and everyone for the info. Somehow it still doesn't crash for me, but I believe we know what the bug is. Going to update to the newest macOS to see if that's the issue because I believe everything else with my environment matches reports here. It's likely a race condition based on the code. We're going to post a change later today that should fix this issue, while still keeping the startup performance zippy (which was the initial reason for the change in 7.5.0 that caused this bug). Could folks try out the change once it comes out? |
Hi all - here's the PR for the proposed fix: |
Update: we've pushed a change to the main branch. Please let us know if this helps! |
I've updated to the latest version and don't see the crash anymore. |
Great, I'm going to close this for now but feel free to reopen if this didn't resolve the problem. |
Using the PR fixes the problem for me too |
Step 1: Describe your environment
CocoaPods
Step 2: Describe the problem
SDK crashes when attempting to calculate saliency using iOS
Vision
framework callingVNGenerateAttentionBasedSaliencyImageRequest()
. The issue is not present in Firebase SDK 7.4.0.Steps to reproduce:
The crash happens whenever the client tries to calculate saliency. It happens on any image 100% of the time. Removing the call to
VNGenerateAttentionBasedSaliencyImageRequest()
or switching to Firebase SDK 7.4.0 avoids the issue and Firebase SDK no longer crashes.The text was updated successfully, but these errors were encountered: