Move to domainURIPrefix for FIRDynamicLinkComponents
#2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new API is optional and current API is fully supported. This reverts commit 46cb564.
ryanwilson
requested changes
Nov 27, 2018
ryanwilson
requested changes
Nov 27, 2018
paulb777
requested changes
Nov 28, 2018
paulb777
reviewed
Nov 28, 2018
…able instancetype return.
ryanwilson
reviewed
Nov 28, 2018
ryanwilson
reviewed
Nov 28, 2018
domain to domainURIPrefix for FIRDynamicLinkComponents
domain to domainURIPrefix for FIRDynamicLinkComponentsdomainURIPrefix for FIRDynamicLinkComponents
ryanwilson
approved these changes
Nov 29, 2018
| @@ -461,14 +462,14 @@ - (void)testLinkOptionsParamsPropertiesSetProperly { | |||
|
|
|||
| - (void)testFDLComponentsFactoryReturnsInstanceOfCorrectClass { | |||
| NSURL *link = [NSURL URLWithString:@"https://google.com"]; | |||
| id returnValue = [FIRDynamicLinkComponents componentsWithLink:link domain:kFDLURLDomain]; | |||
There was a problem hiding this comment.
Sorry, something I just realized now: it'd be good to keep a few tests around still for the old constructor to make sure we don't accidentally break it. I won't block this PR on it, but please add a few tests to make sure the old constructor isn't nil regardless of what's passed in.
There was a problem hiding this comment.
sure, will add more tests for the deprecated constructor.
| NSURL *link = [NSURL URLWithString:@"https://google.com/abc"]; | ||
| FIRDynamicLinkComponents *components = | ||
| [FIRDynamicLinkComponents componentsWithLink:link domain:@"this is invalid domain"]; |
There was a problem hiding this comment.
This would also be good to keep (along with the new nil test) - ensure that an invalid components with the old constructor throws an error.
There was a problem hiding this comment.
sure, will add more tests for the deprecated constructor.
paulb777
approved these changes
Nov 29, 2018
bstpierr
added a commit
that referenced
this pull request
Dec 6, 2018
* master: (26 commits) Functions Interop (#2113) Add a travis cron job for CocoaPod symbol collision testing (#2154) Save schema version on downgrade, add test to verify (#2153) Silence Storage Unit Test `nil` warning. (#2150) Update versions for Release 5.14.0 (#2145) gRPC: fix cases where gRPC call could be finished twice (#2146) Fix Swizzler test warnings (#2144) Update Auth CHANGELOG.md (#2128) Make fuzz tests optional until they pass (#2143) Add support of Game Center sign in (#2127) Add test for deprecated FDLURLComponents init API. (#2133) fix a typo in integration test (#2131) Make fuzzing less verbose to avoid exceeding Travis log limit (#2126) Move to `domainURIPrefix` for FIRDynamicLinkComponents (#2119) Carthage instructions for new gRPCCertificates.bundle location (#2132) Fix pod lib lint GoogleUtilities.podspec --use-libraries regression (#2130) Avoid using default FIROptions directly. (#2124) Changelog entry for LRU GC (#2122) Revert "Add Firebase Source to Header Search Path" (#2123) Custom fdl domain (#2121) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new API is optional and current API is fully supported.
This reverts commit 46cb564.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in a feature request so that we
can discuss it together.